A terribly programmed library

Page: 1 2
ID:71114
 
Jun 1 2009, 3:10 pm
This is a review of a library. Why? Because I just noticed you could review libraries, and I want no one to even attempt to learn from this terrible library.

Why this is terrible, programming wise:
  • It has no use of OOP, the foundation of all modern, proper programming
  • It's as bad as your average source
  • It doesn't use Boolean shortcuts
  • It lacks the ease of reading a library should have (spaces between var=1 is always a plus >_>)
  • It's very repetitive and has nearly no plug and play ability; it's more of a demo, albeit a terrible one
  • Some segments use spaces, while others use tabs
  • Useless loops in statpanel(); this would produce a good bit of overhead in a game with many players
  • Possible extra overhead around istype(src,/mob) (rather than ismob(src))
  • Some usr abuse
  • Lack of a proper death check proc; it's within the Bump() proc (more repetitiveness)
  • Certain things aren't typecasted, which can cause issues (the skills list for example)
  • Useless extra checks for stupid things that shouldn't even be where they are

Presentation:
I liked the beam icon, just because it had that gradient-y style. It was still very subpar, though. Also, everything else is rather bad. This is a library/demo, though, so its understandable.

Originality:
There are much better, more well-known beam libraries out there. Check out Evi of au's beam library or Kaioken's beam demo instead (the latter may still need an update to improve a flaw or two, go nag Kaioken!).

Overall:
You could find better crap in a compost pile.
Jun 1 2009, 3:12 pm
First library/demo review ever?
Jun 1 2009, 3:13 pm
Aixelsyd wrote:
First library/demo review ever?

I think so. This should go in the record books!

Also, I just closed a ul tag I forgot to close. Forgive me!
Jun 1 2009, 3:35 pm
I can't even open libraries of demos anymore. It sucks. I press download and nothing happens.
Jun 1 2009, 4:40 pm
You dont have to use it u asshole <_<
Jun 1 2009, 4:41 pm
Cyberlord34 wrote:
You dont have to use it u asshole <_<

And you don't have to spread terrible programming knowledge, but you choose to anyway, "u asshole <_<".
Jun 1 2009, 4:45 pm
Jeff8500 wrote:
Cyberlord34 wrote:
You dont have to use it u asshole <_<

And you don't have to spread terrible programming knowledge, but you choose to anyway, "u asshole <_<".

I honestly dont give 2 shits what you care about my programming. I could care less to Please you ungrateful assholes. But i just figured id give a few new Libraries to byond and maybe somebody would like them. There was absolutley no need to do a review over this. It was Quite Usuless. If you dont like the Source, dont use it and Stfu.
Jun 1 2009, 4:48 pm
He's right though Cyberlord, if you're going to make libraries, at least make them properly.
Jun 1 2009, 4:51 pm
Howey wrote:
He's right though Cyberlord, if you're going to make libraries, at least make them properly.

Well it was pretty immature to start a Review about 1 little Library. No matter if he liked it our not.
Jun 1 2009, 4:58 pm
Cyberlord34 wrote:
Howey wrote:
He's right though Cyberlord, if you're going to make libraries, at least make them properly.

Well it was pretty immature to start a Review about 1 little Library. No matter if he liked it our not.

You do know that efficiency is important in many things, correct? Why use 10 poorly cared for plants to get as much fruit as you could get with 1 that is properly grown? Well, the same principle applies to programming. Frankly, your library is the 10 poorly cared for plants in that metaphor.

Hell, you can't even call it a library. It has no plug and play capability, which a library has.
Jun 1 2009, 5:00 pm
Jeff8500 wrote:
Cyberlord34 wrote:
Howey wrote:
He's right though Cyberlord, if you're going to make libraries, at least make them properly.

Well it was pretty immature to start a Review about 1 little Library. No matter if he liked it our not.

You do know that efficiency is important in many things, correct? Why use 10 poorly cared for plants to get as much fruit as you could get with 1 that is properly grown? Well, the same principle applies to programming. Frankly, your library is the 10 poorly cared for plants in that metaphor.

Hell, you can't even call it a library. It has no plug and play capability, which a library has.

Are you mentally Retarded? Go download the source, Compile, and Run. You can easily test it. All you have to do is learn the skill and Use it, its simple. All you have to do is be able to read O.o
Jun 1 2009, 5:02 pm
Cyberlord34 wrote:
Jeff8500 wrote:
Cyberlord34 wrote:
Howey wrote:
He's right though Cyberlord, if you're going to make libraries, at least make them properly.

Well it was pretty immature to start a Review about 1 little Library. No matter if he liked it our not.

You do know that efficiency is important in many things, correct? Why use 10 poorly cared for plants to get as much fruit as you could get with 1 that is properly grown? Well, the same principle applies to programming. Frankly, your library is the 10 poorly cared for plants in that metaphor.

Hell, you can't even call it a library. It has no plug and play capability, which a library has.

Are you mentally Retarded? Go download the source, Compile, and Run. You can easily test it. All you have to do is learn the skill and Use it, its simple. All you have to do is be able to read O.o

Are you retarded? That's a complete non sequitor. Being able to run a program does not mean its efficient, nor does it mean it's library material. To be a library, I have to be able to include it in my program without modifying it (I also have to be able to add content like this).
Jun 1 2009, 5:05 pm
Jeff8500 wrote:

Are you retarded? That's a complete non sequitor. Being able to run a program does not mean its efficient, nor does it mean it's library material. To be a library, I have to be able to include it in my program without modifying it (I also have to be able to add content like this).

You can add it. You can put that straight into your game with a simple copy/paste.
Jun 1 2009, 5:07 pm
Cyberlord34 wrote:
Jeff8500 wrote:

Are you retarded? That's a complete non sequitor. Being able to run a program does not mean its efficient, nor does it mean it's library material. To be a library, I have to be able to include it in my program without modifying it (I also have to be able to add content like this).

You can add it. You can put that straight into your game with a simple copy/paste.

You see, you then have to modify it. A library shouldn't require modifications. In C++, some people package their libraries ahead of time so that users don't have access to the source. You can't copy and paste there.
Jun 1 2009, 5:34 pm
Relax. Not everyone is a BYOND guru with over 4 years of DM experience.
Jun 1 2009, 5:45 pm
Cyberlord: Bottom line, you don't understand what a library is, so you really shouldn't be trying to make them for others to use. I realize that when you're relatively new to programming you want to be helpful, but give it a couple of years until you really know what you're doing before you start trying to make libraries.

If you want to create libraries with the goal of learning how to make them and getting feedback from other people on how to improve them, that's one thing, but don't build them expecting others to use them until you have a lot more experience.
Jun 1 2009, 5:47 pm
Congrats on the first review of a library.
Jun 1 2009, 5:47 pm
Foomer wrote:
Cyberlord: Bottom line, you don't understand what a library is, so you really shouldn't be trying to make them for others to use. I realize that when you're relatively new to programming you want to be helpful, but give it a couple of years until you really know what you're doing before you start trying to make libraries.

If you want to create libraries with the goal of learning how to make them and getting feedback from other people on how to improve them, that's one thing, but don't build them expecting others to use them until you have a lot more experience.

alright
Jun 1 2009, 6:06 pm
Cyberlord34 wrote:
Well it was pretty immature to start a Review about 1 little Library. No matter if he liked it our not.

Reading this was so cute, I just had to comment it.

It wasn't really "Immature", he did this in a seemingly peaceful manner. That is, until you started up in the comments for him disliking it.

People can review anything they wish to, regardless if they like it or not as long as they give detail as to why.

The worst thing Jeff could be accused of here is not being more harsh about how it really is. Shame on you, Jefferey!
Jun 1 2009, 6:44 pm
Two problems. One, OOP is hardly a foundation of modern programming, nor is it inherently proper. For example, look at functional languages. Given that DM is an OO language, though, it should use object-oriented programming. Secondly, boolean algebra isn't a shortcut. It's just a method.
Page: 1 2