ID:64128
 
BYOND Version:438
Operating System:Windows XP Home
Web Browser:Firefox 3.0.8
Video Card:
Component:Dream Maker
Game/Hub:
Status: Deferred

This issue may be low priority or very difficult to fix, and has been put on the back burner for the time being.
Descriptive Problem Summary:
When you use CTRL+H in the map editor It seems the Replace/Replace all button is broken, I've tried all of it but I keep getting the message: Pattern not found.

When I press Find, It finds the turfs I want to replace.

Numbered Steps to Reproduce Problem:
Open A map, Press CTRL+H try to replace 1 turf/obj like: /turf/Floor/grass and I want to change it to /turf/Floor/grass2 for example they are both in the list.

Press Replace and Tada.. The error


Expected Results:
It to replace all the turf/Floor/grass to grass2
Actual Results:
Gives me an error

Does the problem occur:
Every time? Or how often? Every time
In other games? Don't know
On other computers? Don't know
In other user accounts? Yes

When does the problem NOT occur?
Always occurs

Workarounds:
Replace all the turfs by hand...
I've been unable to reproduce this, it seems to be working fine for me. Perhaps we need to contact the original poster and get some more details.
Well, I didn't write this yesterday O_o but anywho, It seems to be fixed somehow... might have been my computer...
Nadrew wrote:
I've been unable to reproduce this, it seems to be working fine for me. Perhaps we need to contact the original poster and get some more details.

This error is reproducing for me. Finding a turf will work, attempting to replace said turf with find and replace will result in a "Pattern Not Found" error.

OS: Windows XP Professional
BYOND: 440.1018
GFX Card: Radeon 9200 SE
I tested this on a 10x10 map and had no issue. Perhaps it has to do with the length/complexity of the path? My test changed from one /path to another /path (I tend to override parent_type for my projects; makes 'em easier to read for me).

OS: Windows XP Home
BYOND: 440:1018

I've tried find all (errors out with:
Found 100 objects (max count reached)
), replace all, find next, replace . . . all work fine for me. I'll test with more complicated paths later.

[EDIT] I noticed the OP listed BYOND v.438. Perhaps it was a version issue? Perhaps not as Tiberath reported the issue on 440. Still, might be worth considering.
Ha, there we go.

Attempting to replace /turf/grass with /turf/sand works, however, if you try to replace /turf/grass with say /mob/player it returns the error "Pattern Not Found".

(/mob/player existed in the object tree for me, by the way)

I don't know of this is intentional behaviour or not. But without official word from the powers that be, I'm going to mark this bug report as confirmed seeing as the find and replace does have -some- issue in replacing turfs.
You can only replace atoms by other atoms of the same type. Perhaps we should clarify that in the error message. But it doesn't look like that's what the OP is reporting here.

I have received this error when first initializing a new map and replacing the default turf. It has to do with the way those are stored. I can probably fix it, but it's pretty minor since it only happens in this specific case. If there is a general problem, I have yet to reproduce it.
Tom wrote:
You can only replace atoms by other atoms of the same type.

If that's the intended behavior, could that also be applied to the atom replacer when one is removed through code? I recently saw something in the dev. how to section (I think) where somebody had replaced all their old water turfs with objects, and it caused a bad-world error.