ID:2899489
 
Resolved
When popup browsers were closed, the default browser's on-show command was inappropriately triggered.
BYOND Version:515.1614
Operating System:Windows 11 Home
Web Browser:Chrome 119.0.0.0
Applies to:Dream Seeker
Status: Resolved (515.1621)

This issue has been resolved.
Descriptive Problem Summary:
Closing a browse popup opens the browser element

Numbered Steps to Reproduce Problem:
Open a browser popup and then close the popup

Code Snippet (if applicable) to Reproduce Problem:
mob
step_size = 8
verb
browse_error()
set name = "Open a browse() menu"
set category = "testing"
var/list/output = list()
output += "This"
output += "This too"
usr << browse(output.Join(), "window=thing")


Expected Results:
The browser skin element isn't opened
Actual Results:
The browser skin element gets opened and you are forcefully swapped to that tab
Does the problem occur:
Every time? Or how often? Every time after you open it once
In other games? Yes
In other user accounts? Yes
On other computers? Yes

When does the problem NOT occur?
Doesn't happen on 514

Did the problem NOT occur in any earlier versions? If so, what was the last version that worked? (Visit http://www.byond.com/download/build to download old versions for testing.)
514

Workarounds:

I really don't understand what you're saying in this report. I think part of it is that you're using the word "menu" incorrectly to refer to popup windows rather than menus, and it's muddying the waters, but the description is really lacking in detail.

I tried running your code and couldn't observe anything wrong with the browsers or the popups. That could simply stem from a misunderstanding on my part of what you're saying, or it might be that this code doesn't actually reproduce the issue.
Reproduces for me as described on windows 10 as well. If you'd like video of it: https://youtu.be/o5OPNlbUndo (video may take a bit to process)
In response to Lummox JR
Lummox JR wrote:
I really don't understand what you're saying in this report. I think part of it is that you're using the word "menu" incorrectly to refer to popup windows rather than menus, and it's muddying the waters, but the description is really lacking in detail.

I tried running your code and couldn't observe anything wrong with the browsers or the popups. That could simply stem from a misunderstanding on my part of what you're saying, or it might be that this code doesn't actually reproduce the issue.

When you close the browse() popup window, it shows and forces focus to the default browser skin element in the skin.

Their test code Repos for me on 1614 and 1620 in a both DS and DD hosted world.

edit: I did a byond version bisec, the bug was introduced in 515.1596, and doesn't show up in 515.1595.

Just make a empty project, paste in their script, click the verb, close the browse window popup, observe it showing the default browse control in the default skin to the user.

It seems like the default browse control's onshow is getting ran when a window= browse popup gets closed.
Lummox JR resolved issue with message:
When popup browsers were closed, the default browser's on-show command was inappropriately triggered.