bank problem

ID:266950
 
Sep 2 2002, 10:09 am
right now i have it so that a bank accepts money only, i was wondering if someone could tell me how to make a bank accept items as well, such as capes or foods. If you know how to this post it plz.
Sep 2 2002, 10:31 am
mob/Player
var/list/bank = list()

obj
Bank
verb
Deposit(var/obj/O in usr)
O.loc = usr.bank
Retrieve(var/obj/O in usr.bank)
O.loc = usr
Sep 2 2002, 10:53 am
In response to Garthor
Can you actually set something's loc to be a list?
Sep 2 2002, 10:54 am
In response to Lesbian Assassin
Probably, since usr.contents is a list. If not, just...

new O(usr.bank)
del(O)

Should work. I haven't tested it yet though.
Sep 2 2002, 11:05 am
In response to Garthor
Nope, I just checked... .contents is a special list. Anyway, when you move something into a character's inventory, you don't put o.Move(usr.contents), you put usr.contents += o (which, by virtue of the specialness of .contents, handles the moving by itself) or o.Move(usr).

Your first code would work, except you need to separate out the act of moving the item to and from the usr's contents and the act of adding/subtracting it from usr.bank

For depositing, you would have
usr.bank += o
o.Move(null)

For withdrawing, you would have
o.Move(usr)
usr.bank -= o
Sep 2 2002, 11:08 am
In response to Lesbian Assassin
IC, I haven't toyed around with contents and lists very much. I thought contents was just a normal list. =P
Sep 2 2002, 11:50 am
In response to Garthor
Garthor wrote:
mob/Player
var/list/bank = list()

obj
Bank
verb
Deposit(var/obj/O in usr)
O.loc = usr.bank

Wrong.
A list is not a valid loc; O.loc=usr.contents would be just as wrong (the correct version would be O.loc=usr, as you used for retrieval). The loc is an atom, not a list. Just because something's in a list doesn't mean it's physically contained in the list.
However, because you have obj/Bank, you can actually move the obj you're depositing into src (the bank).

The way I'd do this would be to give my bank a separate deposit box for each player.
obj/bankvault
  var/list/depositors

  New()
    ..()
    depositors=list()

  proc/AccountID(mob/M)
    if(M.client) return "[M.client.ckey]:[ckey(M.name)]"
    return ":[ckey(M.name)]"

  proc/GetBox(account)
    var/obj/depositbox/B=depositors[account]
    if(!B)
      B=new(src)
      depositors[account]=B
    return B

  proc/Deposit(mob/M,obj/O)
    var/obj/B=GetBox(AccountID(M))
    if(!(O in M)) return
    O.loc=B
  proc/Withdraw(mob/M,obj/O)
    var/obj/B=GetBox(AccountID(M))
    if(!(O in B)) return
    O.loc=M
  proc/ContentsOfBox(mob/M)
    var/obj/B=GetBox(AccountID(M))
    return B.contents

Lummox JR