render_source and render_target cannot be used with bloom filter

ID:2653021
 
Feb 5 2021, 1:28 pm
Resolved
The "measurement" phase of the bloom filter was handled incorrectly, resulting in very strangely broken results for some cases.
BYOND Version:514.1544
Operating System:Windows 10 Pro 64-bit
Web Browser:Chrome 87.0.4280.141
Applies to:Dream Seeker
Status: Resolved (514.1546)
This issue has been resolved.
Descriptive Problem Summary:
When render_source and render_target are used in conjunction with the new bloom filter, the renderer will crash and go black.

render_group
    parent_type = /obj
    screen_loc = "CENTER"


mob/proc
    AddGroup(render_group/group)
        if(!client) return
        client.screen += group

render_group
    streetlights
        icon = 'assets/urban-accessories.dmi'
        icon_state = "GC_UA_D_026"
        render_target = "*streetlights"
        filters = list(filter(type="bloom",threshold = rgb(224,232,234), size = 5, offset = 1, alpha = 255))

obj
    lights
        light_top
            layer = 5
            render_source = "*streetlights"
Feb 6 2021, 10:33 pm
Can you throw a test case together for this so we're on the same page?
Feb 6 2021, 11:04 pm
Feb 7 2021, 3:47 pm
Lummox JR resolved issue with message:
The "measurement" phase of the bloom filter was handled incorrectly, resulting in very strangely broken results for some cases.