Loop is not finding the mob

ID:264833
 
Nov 21 2010, 1:29 pm
Code:
#define DEBUG

world
    mob=/mob/Player/

mob/Player/Login()

mob/pokemon/pikachu
     icon = 'Pikachu.dmi'

mob/var
    list/pokemon=list(new/mob/pokemon/pikachu)

mob/pokemon/var
    Level = 0
    list/Attacks=list("E")

Attacks/proc
    Tech(mob/A)
        for(var/mob/pokemon/b in A.pokemon)
            if(istype(b, /mob/pokemon/pikachu/))
                if(b.Level == 5)
                    src.Learn(b,"Tackle",A)

    Learn(mob/pokemon/a,attack,owner)
        world << "debug"
        owner << "[a] learned [attack]"
        a.Attacks+=attack

mob/verb/Lol()
    new/Attacks(src)

Attacks/
    New(mob/A)
        world << "Test 1 (Calling New): Passed"
        for(var/mob/pokemon/b in A.pokemon)
            world << "Test 2 (Looping for Pokemon in A.pokemon): Passed"
            if(istype(b, /mob/pokemon/pikachu/))
                world << "Test 3: (If b is a Pikachu): Passed"
                if(b.Level == 5)
                    world << "Test 4: (If Level is 5): Passed"
                    src.Learn(b,"Tackle",A)

    Learn(mob/pokemon/a,attack,owner)
        world << "debug"
        owner << "[a] learned [attack]"
        a.Attacks+=attack


Problem description: In Attacks New() it just goes to Part 1. o.O

Nov 21 2010, 1:41 pm
The most obvious problem is that you are using new inside of list(), which usually doesn't work. Instead, try newlist() and remove the new from /mob/pokemon/pikachu. However you will have to define it like so:

mob/New()
    ..()
    pokemon=newlist(/mob/pokemon/pikachu)
    // you can add more pokemon by adding more types to the newlist() proc, like so:
    // newlist(/mob/pokemon/pikachu,
    //         /mob/pokemon/squirtle,
    //         /mob/pokemon/mudkipz)
Nov 21 2010, 1:50 pm (Edited on Nov 21 2010, 2:08 pm)
In response to Duelmaster409
It's not working... o.O

EDIT: Nvm fixed.

EDIT 2: Is there another way to do this? Since, i will do over 300 attacks. o.o
Nov 21 2010, 3:12 pm
In response to Ocean King
That's why there are for() loops.
Nov 21 2010, 7:39 pm
In response to Ocean King
Yes, there's another way to do this. I'd start with a global associative list, such that the key is the pokemon type, and the value is a list of moves learned, such that index X is the move learned at level X. So, for example, you'd have:

var/list/moves_learned = list(
.pikachu = list(.thrash,,,,.shock),
.whoeverelse = list(.thrash,,,,,,,,,.level10move)
)


Then, whenever a pokemon levels up, you can find the type of the move they should learn by just accessing moves_learned[src.type][src.level]
Nov 22 2010, 3:32 am
In response to Garthor
Other is doing this:

var/list/All_Attacks=list(new/obj/Attacks/Grass/Absorb/)

Then in Pokemon learn:

src.Learn(All_Attacks[1]) // Learns the first attack of the All_Attacks list


if i'm not wrong. :P
Nov 22 2010, 9:35 am
In response to Ocean King
No.

That is wrong.
Nov 23 2010, 5:44 am
In response to Duelmaster409
Duelmaster409 wrote:
you are using new inside of list(), which usually doesn't work

Since when has this not worked? If this is true, it must be a bug that was introduced recently and should be reported. You should not be having any problems creating new objects in lists.

Before submitting this post, I decided to run a test. I just made the following as a few test cases.
mob/verb/f()
    var/list/L = list(new /obj, new /mob, new /area, new /savefile)
    for(var/x in L)
        src << "[x]"

I then ran it and executed f(), and I received the following output as expected.

The obj
The mob
The area
C:\Users\me\Documents\BYOND\cache\C94ED88

2nd
mob/var/list/L = list("1", "2")
mob/verb/f()
    src << "The list has [L.len] things and contains the following:"
    for(var/x in L)
        src << "[x]"

Output is as expected:

The list has 2 things and contains the following:
1
2

3rd
mob/var/list/L = list(new /obj, new /mob)
mob/verb/f()
    src << "The list has [L.len] things and contains the following:"
    for(var/x in L)
        src << "[x]"

This produces a runtime error stating that it cannot access ".len" which is extremely odd. If L was null, it should say "null.len" Indeed, if you add if(!L) and if(L == null) checks, it doesn't see L as null nor as false.

If you take away the [L.len] part it compiles and runs fine but doesn't output anything in the loop.

using newlist(/obj, /mob) produces the same output as above, it still does not work.

I just checked the creation of new objects in a field initialization at all
mob/var/obj/O = new
mob/verb/f() src << O

And that doesn't even work. I KNOW that used to work.

Indeed, this must be a bug or a change in the language spec; I'm going to report it.