Global Ban, Code Failure

ID:264591
 
Dec 27 2009, 3:15 pm
Code:
proc/GlobalBan()
    world<<"<font color = red><b>GM: </font></b><b>Updating Global Ban List"
    var/http = world.Export("http://www.gohangames.webcindario.com/global ban.txt")
    if(!http)
        usr << "Failed to connect."
        return
    var/G = http["CONTENT"]
    if(G)
        usr << html_encode(file2text(G))
        world<<"<font color = red><b>GM: </font></b><b>Global Ban List Succesfully Updated"
    for(var/mob/M in world)
        if(M.key in G)
            M<<"Banned. Stfu Test =D"


Problem description: Well, for Some Reason The Message of M<<"Banned. Stfu Test =D" Doesnt Appear.

Dec 27 2009, 4:25 pm (Edited on Dec 27 2009, 4:48 pm)
 
proc/GlobalBan()
    world<<"<font color = red><b>GM: </font></b><b>Updating Global Ban List"
    var/http = world.Export("http://www.gohangames.webcindario.com/global ban.txt")
    if(!http)
        usr << "Failed to connect."
        return
    var/G = http["CONTENT"]
    if(G)
        G=html_encode(file2text(G)) //you only html_encode() and file2text()'d the input to the world and were looping though an html file
        world<<G
        world<<"<font color = red><b>GM: </font></b><b>Global Ban List Succesfully Updated"
        for(var/client/M) //only loop if(G)
            if(findtext(G,M.key)) //G isn't a list, you can't use "in".
                M<<"Banned. Stfu Test =D"
Dec 27 2009, 4:45 pm (Edited on Dec 27 2009, 4:51 pm)
In response to Ruben7
Infinite loop suspected--switching proc to background.
If it is not an infinite loop, either do 'set background=1' or set world.loop_checks=0.
proc name: Update Global Ban (/mob/GM/verb/Update_Global_Ban)
usr: Revolution Gohan (/mob/Player)
src: Revolution Gohan (/mob/Player)
call stack:
Revolution Gohan (/mob/Player): Update Global Ban()
Dec 27 2009, 4:50 pm
In response to Revolution Gohan
Show me the Update_Global_Ban() verb.

Also change:
"for(var/client/M in world)" to "for(var/client/M)"
Dec 27 2009, 4:51 pm
In response to Ruben7
 

mob/GM/verb/Update_Global_Ban()
    set category = "GM"
    world<<"<font color = red><b>GM: </font></b><b>Updating Global Ban List"
    var/http = world.Export("http://www.gohangames.webcindario.com/global ban.txt")
    if(!http)
        usr << "Failed to connect."
        return
    var/G = http["CONTENT"]
    if(G)
        G=html_encode(file2text(G)) //you only html_encode() and file2text()'d the input to the world and were looping though an html file
        world<<"<font color = red><b>GM: </font></b><b>Global Ban List Succesfully Updated"
        for(var/client/M in world) //only loop if(G)
            if(findtext(G,M.key)) //G isn't a list, you can't use "in".
                M<<"Banned. Stfu Test =D"




Oh and a Verb to Add the Key to global ban.txt without editing the file?