Confusing icon states

ID:263079
 
May 4 2006, 7:11 am (Edited on May 4 2006, 4:40 pm)
Code:
            Click()
                if(get_dist(src, usr) > 1) return
                var/obj/tool/WC = /obj/tool/Watering_Can
                var/obj/tool/H = /obj/tool/Hoe
                for(WC in usr.contents)
                    if(WC.suffix == "Equipped")
                        src.icon_state = "wet dirt"
                        src.is_wet = 1
                for(H in usr.contents)
                    if(H.suffix == "Equipped")
                        src.icon_state = "tilled dirt"
                        if(src.is_wet == 1)
                            src.icon_state = "wet tilled dirt"
                            if(is_night)
                                src.icon_state = "tilled wet night"


Problem description:
When using the WC, it confuses the icon_states set for H and does "tilled wet night" instead of "wet dirt".

May 4 2006, 7:14 am
You're setting is_wet to 1, then starting another loop which checks if(is_wet)
May 4 2006, 4:46 pm
In response to Mysame
I just noticed that the spacing was off, *Edits*.

Anyway, that shouldn't matter (now that the spacing is right) because that should only come into effect only when "H" is has the suffix "Equipped", correct? I think so, but I'm tired and not thinking straight right now -_-;.
May 5 2006, 12:36 am
Pyro_dragons wrote:
Code:
>             Click()
>               if(get_dist(src, usr) > 1) return
>               var/obj/tool/WC = /obj/tool/Watering_Can
>               var/obj/tool/H = /obj/tool/Hoe
>               for(WC in usr.contents)
>                   if(WC.suffix == "Equipped")
>                       src.icon_state = "wet dirt"
>                       src.is_wet = 1
>               for(H in usr.contents)
>                   if(H.suffix == "Equipped")
>                       src.icon_state = "tilled dirt"
>                       if(src.is_wet == 1)
>                           src.icon_state = "wet tilled dirt"
>                           if(is_night)
>                               src.icon_state = "tilled wet night"

Problem description:
When using the WC, it confuses the icon_states set for H and does "tilled wet night" instead of "wet dirt".


Use RETURN