Label problem

ID:262079
 
Aug 15 2004, 11:09 am (Edited on Aug 15 2004, 11:17 am)
Here is the snippet of relevant code:
            flowers:
                for(var/turf/T in l)
                    if(prob(flowerDensity))
                        for(var/obj/overmap/flower/F in T) continue flowers
                        new /obj/overmap/flower (T)
Notes: The purpose of the above snippet is to make sure flowers are only placed on turfs that do not contain any flowers previously.
l is a list of turfs to check
flowerDensity is set to 100 for testing purposes

The error I get when I compile this code is as follows:

Overmap.dm:24:error:flowers :continue failed

Note that line 24 is marked in the snippet above.

Does anyone know what this error means or what I should do to fix it? Thanks in advance.

-LoW
Aug 15 2004, 12:26 pm
Instead of this:
for(var/obj/overmap/flower/F in T) continue flowers
new /obj/overmap/flower (T)

You could just do this:
var/obj/overmap/flower/F=locate()in T
if(!F)new /obj/overmap/flower (T)

For one thing, you don't need to loop since you are only searching for a single one. For another, continue is evil unless really needed, which it is not in this case since something else is better.

Also, you are continuing to a point outside of the loop. I don't do a lot with that sort of nonsense in DM; but I can tell you that it would not work in other programming languages I have used. Perhaps, if you really want to use continue, you could try putting the flowers pointer inside the outside loop.
Aug 15 2004, 4:22 pm
You don't actually need the label here. An ordinary continue would do just fine.

Lummox JR