Verb is sporadically breaking

ID:2568750
 
May 7 2020, 6:12 pm
(See the best response by Nadrew.)
Code:
    verb/View_Card_Changes()
        set src in usr
        set category = null

        usr << "<br><i>If you don't see the window, it might be off the right-hand side of your screen. Try dragging it on to the screen.</i><br>"
        usr.currency_item_changes(src)

        return



    currency_item_changes(obj/items/currency/I)

        set hidden      = 1

        if(!I) return

        if(I.c_change.len)
            var/list/item_cards = list()
            var/list/currency_item = list()
            currency_item += I
            var/j_fuse = 0
            if("*JADEN FUSION*" in I.c_change)
                j_fuse = 1

            for(var/obj/cards/C in cards)
                if(C.name in I.c_change)
                    item_cards += C
                else if(j_fuse)
                    if(C.fusion) if(findtext(C.name,"HERO"))
                        item_cards += C
            for(var/obj/cards/C in item_cards)
                var/c_dup_check = 0
                for(var/obj/cards/CC in item_cards)
                    if(C.name == CC.name)
                        c_dup_check++
                        if(c_dup_check > 1)
                            item_cards -= CC

            if(!item_cards.len)
                usr << "<i>Can not find any cards in your item's change list. Report this.</i>"
            else
                usr.Currency_Change(item_cards,,,currency_item,1)

        return


Error example...

on item /obj/items/currency/character/fd/yusei
(Name is "Yusei Fudo")

Sorry, the following is not valid: Yusei-Fudo
usage: View-Card-Changes obj in inventory


Problem description:

So I'm having some issues with verbs attached to objects all of a sudden.

I recently updated to the beta build and im not sure if this is causing the problem or not because this code has not been changed in months and has never given me any trouble in the past.

I will use the View_Card_Changes on an object via right-clicking on it. And sporadically the verb will just fail. Same obj. Same server. Same session. I can use it, it works just fine, then 5 seconds later use it again and I'll get the error.
May 7 2020, 10:41 pm
Sorry, the following is not valid: Yusei-Fudo
usage: View-Card-Changes obj in inventory

Given this error message, it looks like the command Dream Seeker was issued was literally "Yusei-Fudo", rather than the verb that you defined. Hmm.

I'm not convinced that the currency_item_changes proc itself is relevant, here. Maybe Currency_Change is the culprit?

Can you reproduce the issue if you comment out these lines?
else
    usr.Currency_Change(item_cards,,,currency_item,1)
May 8 2020, 10:43 am
Yusei-Fudo isnt a command though. It's the name of the obj.

But its passing the obj itself, not the name of the obj.

currency_item_changes() adds the item in to a list and passes that list on to Currency_Change()

The reason for that is that the verb Currency_Change() serves 2 purposes.

1. it can report all the changes that item can do to the player which is what is happening in this case.

2. it can apply those changes when a match starts. In which case, the match start proc will pass a list of all of the items in the player's inventory to the proc instead of this verb which just passes the singular item in a list.

I'll try to comment it out and see what happens.
May 8 2020, 3:13 pm
Probably not your problem, but is usr really usr in the case of currency_item_changes()?

This looks like a BYOND bug to me.
What happens if you go back to public build?
May 8 2020, 5:25 pm
Best response
You should actually make sure you're running the latest BYOND beta build. The last couple of beta builds had some issues with verbs due to how the code was changed.
May 11 2020, 8:40 pm
After playing with this a bit more, its not just this 1 verb breaking. Seems like every verb I have attached to an obj is breaking. I can use the verb one time and get it to run and then use it again and it'll fail.

Here's another one using the command List() on an obj called "Kaijus". It should show a list of the contents of that item.

Sorry, the following is not valid: Kaijus
usage: List obj
usage: view-effect-list
usage: view-attack-list
usage: view-chant-list
usage: staff-list
usage: Forbidden-List (Adjust Forbidden List)
usage: Who-List (Advanced WHO command - reports all people connected)
usage: Field-Spell-List (Spawns a Sealed Pack Deck)
usage: Equip-Spell-List (Spawns a Sealed Pack Deck)


Im running in 513.1521 at the moment. I'll try to update to the newest to see if that fixes it
May 12 2020, 12:33 am
Updating to 513.1522 fixed the issue. This version sneaked up on me since I just updated a few days prior.