Output Issue in Beta Build

ID:2565659
 
Apr 28 2020, 8:51 pm
(See the best response by Lummox JR.)
https://gyazo.com/2940b57e45b3cafea92f5a93ff20fc13

C.mob << {"<a title ="[usr.key]" href=byond://?src=\ref[usr];action=pm><IMG SRC=\ref[usr.avatar] width="18" height="18"></a><b>\[[time2text(world.timeofday,"hh:mm")]\]</b> <b>[u_name]: </font></b>[NaughtyCheck(check_msg,C.mob.Config["f"])]"}


In my game, when a player talks, it displays their avatar. Then the time, their name, and then the player's text.

The avatar picture can be clicked on to bring up a PM window directed toward that player.

Never had a problem with this before but recently some players have been reporting this problem but only when using the Beta client which I'm not really working with at the moment.

Note that the code here has been something we've had in place for quite some time and it works perfectly fine in the stable release.

I've been going over the patch notes for the beta build and I cant seem to find any changes that would be causing this.

Anyone have any idea what's causing it?
Apr 28 2020, 9:10 pm
Your poorly formatted HTML is probably throwing off the parser, which was improved on from 512 due to maptext changes.

At a quick glance you have an awkward space after your "title" parameter.
Apr 30 2020, 10:45 pm
Best response
Oddly the parser changes in recent builds should not have impacted this, but Nadrew's right that the formatting is crap. I'm curious if this goes away if you fix it.

I would actually regard this as a bug, but I'd need to know which builds those players were using and I'd need a test project.
May 3 2020, 1:22 pm
 
C.mob << {"<a title="[usr.key]" href='byond://?src=\ref[usr];action=pm'><IMG SRC=\ref[usr.avatar] width="18" height="18"></a><b>\[[time2text(world.timeofday,"hh:mm")]\]</b> <b>[u_name]: </font></b>[NaughtyCheck(check_msg,C.mob.Config["f"])]"}


The above code is working now. It wasn't the space after title that was causing the problem. I had to add ' around the href segment. Without those it was just treated it as text. This was never an issue before.
May 3 2020, 9:07 pm
In response to IceFire2050
You should really be using double quotes for an attribute like that, never single.

If you're able to isolate a version where the issue appeared it might help me track down why it started happening. I don't recall making any changes to the HTML parser that would have caused something like that.
May 5 2020, 3:04 pm
Beta Client
https://i.imgur.com/wP7RfMK.png

Stable Client
https://media.discordapp.net/attachments/464543328172507149/ 707334346369007676/unknown.png

Now that the output itself isn't throwing up html all over my chat, I've now noticed that my avatars have a new issue in chat. They're getting an underline appearing. Every player's avatar has a greenish line appearing 2 pixels below the avatar itself.

Judging by the color of the line, this seems to be because they are links. Its the same color the hyperlink text in chat and the line under the image is the same as the line under the hyperlink in chat.

This was never the case in the stable build in the past and players running the stable build still dont see these lines, only the beta client.
May 5 2020, 3:47 pm
That's actually expected in this case, the fact it wasn't showing before was the issue. The image is surrounded with a link tag.

If you want the line to disappear you need to use CSS to alter the text-decoration of links (and probably make the link around the image a unique class so you can only disable the line for those)