ID:2463560
May 6 2019, 7:21 pm (Edited on May 7 2019, 12:15 pm)
(See the best response by Popisfizzy.)
|
|
Code:
mob Problem description: Login.dm:126:error: bad argument definition Line 26 is below usr.Move. If it's relevant, there is a load/save overwrite for location on Logout(). Edits: to show a different thing I tried. | |
|
May 6 2019, 7:50 pm
Best response
|
|
Popisfizzy
 |
The problem is that everything under Login() should be indented by one more tab. Nevertheless, there's some other, less-obvious problems with this code that also need resolved. I would advise reading the DM guide.
|
I have been reading the DM Guide extensively.
Let's take it back to basics because that is my skill level! I used the DM Guide to begin my load/save adventure. The bad argument error simply masked a whole bunch of other errors, which all began when following the DM Guide tutorial for save/load. The majority of the errors refer to DM not recognizing SaveFile - but it's supposed to be an object in DM already. Does it require further definition? | |
mob I have tried adding 1 million variations to this portion of code. The end goal is to check for a savefile and otherwise send players to create_character. I am wondering if: a.) They all need to start in create_character and if(saveile exist) it needs to then send them to saved coords, b.) Login() can be used in multiple places? How do you 'proc' the switches for create_character if a player is 'moved' to it? | |
Try this text about Login()
Login() --src<<"Hello" --..() Login() ..() --src<<"123" Login is like a river, u put a boat in the middle | |
But... is it the only boat? How many different places can this river take the boat?
Login() isn't the issue, the issue is savefile and DM not 'recognizing' it. I'll do another couple tests and share my results. | |
mob Returns: Login.dm:69:error: SaveFile.cd: undefined var Login.dm:70:error: SaveFile.dir: undefined var Login.dm:71:error: SaveFile.cd: undefined var Login.dm:72:error: SaveFile: undefined var | |
mob/var/list/V Of the my game | |
mob/Logout() | |
ob/SM7/verb/Recrutar() | |
obj | |
world | |
mob/proc/Load1() Load | |
client/New(){..();if(mob)src.mob.cansave=0}Login | |
Way too much irrelevant information in Klogaum's response, so I'm just gonna start fresh with you, Keynote. The problem is that Savefile is not defined:
Login.dm:69:error: SaveFile.cd: undefined var Login.dm:70:error: SaveFile.dir: undefined var Login.dm:71:error: SaveFile.cd: undefined var -> Login.dm:72:error: SaveFile: undefined var You can fix this by declaring Savefile somewhere in the scope of the proc you are planning to use it:
var/Savefile
This is covered more in depth in the DM guide, chapter 5 section 4: the Life of a Variable http://www.byond.com/docs/guide/chap05.html And also that Savefile is not the right kind of variable: -> Login.dm:69:error: SaveFile.cd: undefined var -> Login.dm:70:error: SaveFile.dir: undefined var -> Login.dm:71:error: SaveFile.cd: undefined var Login.dm:72:error: SaveFile: undefined var You can fix this by declaring a type for savefile:
var/savefile/Savefile
Declaring a type for variables tells the compiler that they are a specific type of object, and this will allow you to use their unique variables, procs and verbs without the compiler complaining about it. This is covered more in depth in the DM Guide, chapter 5 section 2.2.1 Declaring Variable Types: http://www.byond.com/docs/guide/chap05.html | |
I did want to take the time to point out that you have a lot of redundant code, as well as more than just those two issues I mentioned, but because I don't have enough information to be sure that my assumptions are correct, I wanted to only point out the most obvious errors.
Your redundant code can be reduced by instead of using a different type for every single possible combination of character stats, by using a list to store different icons and changing the player's icon to match any premade character appearances. You can also do this programmatically by making the player's skin its own icon and shifting its colors with color matrices or via icon operations if you so desire. You could also include male and female distinctive features as overlays and underlays of the player's icon and use the neutral gender as the base state if you so chose, so you have a lot of options. But there are a few options for addressing redundant code: using the list-based approach: //create a 2D associative list of character icons by gender x tone: Still using types, but using text2path(): //declare two associative lists that store user-friendly names for tones and gender associated with code-friendly values: There is another issue with the code you linked: Your code clearly belongs under mob/create_character, but because of your tabbing, you have inserted it under /mob. mob That's how it should look instead. | |
I suffer from anxiety
Ur post was good to me, to remember the options and ... my read() never give me problem on my way (NEVER) i HAD ERRORS BUT IN THIS SCHEME I NEVER if logout dont proced, roll back ten minutes, events importants like drop item, save at the time | |
Thank you, Ter!
After a lot of soulsearching and re-reading all the tutorials again, I did find many of my mistakes. I was aware of the excess of code, mainly used so I could test a working model before breaking into the whole list thing. I was misunderstanding how paths/directories work, but I finally have a handle on that as well. What I am left with is a cyclical character creation which I hoped to fix by placing our save code directly under mob. mob I have read your tutorial like 50 times now, with a new epiphany each time! The end goal is to have a start screen where you select 'Load' or 'New', but I have only been playing in Dream Maker for a couple weeks. I'm just laying the groundwork here for all of the next steps, so I can learn it from inside and out. Back to character creation... I am working on the lists thing. In the mean time, how do I end this so the new var/mob/character is properly switched with src and we can move along and play the game? mob Edit: Typo and clarification. | |
So, Login() is called every time a client's mob is switched. That's why character creation/handling being under /mob is a bad idea.
An example of how to go about what you are trying to do: //declare two associative lists that store user-friendly names for tones and gender associated with code-friendly values: The important bit is understanding all the different moving parts of what you are trying to do. The basic cycle should go: 1) If the player has an existing savefile, automatically load that savefile and pull the saved mob out of it. 2a) By default, the mob's current key should save. This will automatically switch the client to the mob saved in that savefile, calling client/Logout(), which will destroy the create_character mob. 2b) If the player does not have an existing savefile, create a new character and manually change the client's mob to the new player we created. 3) The player is now logged into the new mob. 4) When the player logs out, Save() the mob into a savefile and destroy the mob. | |
Working on it still. As per usual, I will try one-thousand different variations before it (hopefully) works.
Getting this: runtime error: Cannot create objects of type null. proc name: Login (/mob/create_character/Login) usr: (src) src: Ted Talks (/mob/create_character) src.loc: null call stack: Ted Talks (/mob/create_character): Login() | |
