Option for overlays to ignore parent dir

ID:2289124
 
Aug 31 2017, 8:18 am
Applies to:DM Language
Status: Open
Issue hasn't been assigned a status value.
Whenever you have an overlay, the dir var of the overlay is always overriden by the parent object. I would like to see an appearance flag called RESET_DIR or something that prevents this behavior, and the overlay would select it's own dir.
Aug 31 2017, 12:44 pm
If you set the overlays's dir explicitly, this should prevent the parent dir from coming through. There's actually an internal flag for this.
Aug 31 2017, 1:22 pm
How do you set the overlays dir explicitly?
Aug 31 2017, 1:47 pm
If you're simply adding an icon state like "active", or an icon, or a type path, that won't do it. But this ought to:

var/obj/O = new
O.icon = 'halo.dmi'
O.dir = EAST
src.overlays += O

Because O.dir was set explicitly, the appropriate flag should be set for that appearance when it's used as an overlay.
Aug 31 2017, 2:13 pm
This doesn't seem to work for me. I've tried this with a mutable_appearance, image object, and a normal object and none of them work.
Aug 31 2017, 2:40 pm
Can you post some code you're using for this purpose?
Aug 31 2017, 3:40 pm
 
    var/list/L = list()
    overlays.Cut()
    for(var/IDX in 1 to 20)
        var/mutable_appearance/A = new /mutable_appearance()
        A.icon = 'icon.dmi'
        A.icon_state = "arrow"
        A.dir = pick(1,2,4,8)
        A.transform = new /matrix(1, 0, rand(-32,32), 0, 1, rand(-32,32))
        L += A
    overlays = L
Sep 1 2017, 2:04 am
It only works correctly if you use the image() proc and set the dir as an arg in that.
Sep 1 2017, 6:42 am
Well lummox should expose the internal flag.
Sep 1 2017, 11:48 am
Because O.dir was set explicitly, the appropriate flag should be set for that appearance when it's used as an overlay.

DM has never obeyed this rule.

It has always ignored the overlay dir in favor of the parent object's dir. Always.
Sep 1 2017, 6:17 pm
(unless you set it in image in the image() proc)