EffectLib

by Ter13
Handle generic temporary combat effects efficiently and cleanly
ID:2287704
 
Resolved
Mistakes were made.
BYOND Version:511
Operating System:Windows 10 Home 64-bit
Web Browser:Chrome 60.0.3112.101
Applies to:EffectLib 2.1
Status: Resolved (2.2)

This issue has been resolved.
Descriptive Problem Summary:
On Line 103, Ticked() is given ++ticks as its second argument. This argument does not exist in the proc signature on Line 153 or in the documentation.

I haven't compiled/tested any code with this yet; so, I'm not sure if its a problem. It seemed like something strange/worthwhile to point out at the very least.

Numbered Steps to Reproduce Problem:

Code Snippet (if applicable) to Reproduce Problem:
// Line 103
Ticked(target,++ticks,world.time) //call the Ticked() hook. This is another override that allows you to define what these ticker effects will do every time they tick.

// Line 153
Ticked(mob/target,time=world.time) //Ticked() is called when a ticker effect successfully reaches a new tick.


There's actually a really crippling bug in ticker datums right now I haven't pushed the fix for. A fix is coming once I do some more testing.
Ter13 changed status to 'Verified'
Ter13 resolved issue with message:
Mistakes were made.