Assigning a value to a mobs (c)key that already has a client causes logout to not be called.

ID:2282749
 
Aug 13 2017, 3:24 pm (Edited on Oct 10 2017, 2:23 pm)
Resolved
Logout() was not called when a mob's key change caused a client to disconnect.
BYOND Version:511
Operating System:Windows Server 2012 R2 64bit
Web Browser:Chrome 61.0.3163.39
Applies to:Dream Daemon
Status: Resolved (512.1398)
This issue has been resolved.
Descriptive Problem Summary:

Setting a mob's ckey to another ckey while it already has a ckey attached will not trigger Logout(). (this actually vaguely sounds familiar. I'm remembering a convo about this in our coder channel years ago, but I was unable to find a bug report on it.)

See post below with more details
Aug 15 2017, 9:06 pm
To be clear on this, the winget() is happening before Logout()?

I'm not sure how Logout() could fail to be called at all, really.
Aug 15 2017, 10:31 pm
I attempted to reproduce this but was unable.

Basically, the pattern is that we get a bad client runtime relating to some win* call followed almost immediately by a bunch of null ref runtimes relating to lists that are maintained by login/logout.

I had thought the bad client runtime was a clue (as it showed just before the null ref runtimes in the last few cases). but it turns out it's likely just another symptom.

I have of course done the normal checking for ..() on all of our Logout overrides. This was my first assumption.


I'm not sure how Logout() could fail to be called at all, really.

Ya, I started focusing on this after I was unable to reproduce with winexists or winget.

And I found the answer! (as I was typing this post, because that's when all my best ideas happen)

Setting a mob's ckey to another ckey while it already has a ckey attached will not trigger Logout(). (this actually vaguely sounds familiar. I'm remembering a convo about this in our coder channel years ago, but I was unable to find a bug report on it.)

Normal (del())
client/New()
mob/New()
mob/Login
mob/Logout
mob/Del()
client/Del()


Also normal (having the client run .reconnect)
client/New()
mob/New()
mob/Login
client/Del()
mob/Logout


Abnormal (setting the mob's ckey to null.)
client/New()
mob/New()
mob/Login
client/Del()

Aug 15 2017, 10:42 pm
Ooh! Good info. I'll see what I can find here.
Oct 5 2017, 10:53 pm
Bump
Nov 30 2017, 9:10 pm
bump
Dec 1 2017, 10:46 am
Yeesh, I meant to get to this sooner. Apologies for letting it fall through the cracks. It probably won't get into the next release (I'd like to get that out today if feasible) but I'll see what I can do after that.
Dec 8 2017, 1:32 pm
Lummox JR resolved issue with message:
Logout() was not called when a mob's key change caused a client to disconnect.