Push

ID:227401
 
Jan 30 2012, 9:24 am
(See the best response by Kaiochao.)
Code:
mob/verb/push() 
    usr.Push()  
    
mob/proc/Push(obj/Box/A)
    if(istype(A))
        if(step(A,src.dir))
            step(src,src.dir)
                                    
obj
    Box
        icon = 'obj.dmi'
        icon_state="roof1"
        density = 1
        layer = 5


Problem description:

this code i tried will not work at all can i get some help
Jan 30 2012, 9:26 am
When you call your proc you need to pass argument.

I think you should look at Bump() proc if you want to push boxes.
Jan 30 2012, 9:42 am
i want to use it as a verb not a bump
Jan 30 2012, 9:44 am
In that case you could look into locate() proc. Use it to find box in front of character, then pass it as argument to the proc you posted in original post.
Jan 30 2012, 11:40 am
Best response
You forgot a locate(). get_step() only gets the turf, while you're looking for an object inside it.

I would also avoid using the same names for verbs and procs. If it can't be helped, the verb name should take preference in capitalization.

Also, for the Push() proc, I would rather have only one argument and use src inside of it. Besides, your example moves the pusher, not the pushed.
mob
    verb/Push()
        for(var/obj/box/b in get_step(src, dir))
            push(b)

    proc/push(atom/movable/b)
        if(!istype(b)) return
        step(b, dir)