Client Hidden Verbs don't work

ID:2192937
 
Dec 28 2016, 1:59 pm (Edited on Dec 28 2016, 3:36 pm)
BYOND Version:510
Operating System:Windows 7 Home Premium 64-bit
Web Browser:Chrome 55.0.2883.87
Applies to:Dream Seeker
Status: Unverified
Thus far we've been unable to verify or reproduce this bug. Or, it has been observed but it cannot be triggered with a reliable test case. You can help us out by editing your report or adding a comment with more information.
client
    var
        ping = 0
        ping_id = 0
    verb
        ping(time as num)
            set instant = 1
            set hidden = 1
            set waitfor = 0
            var/value=100
            if(world.tick_usage>100)
                value=world.tick_usage
            ping = (world.time+world.tick_lag*world.tick_usage/value)-time
            var/lping = (ping_id+1)%10000000
            ping_id = lping
            sleep(1)
            if(ping_id==lping)
                winset(src,null,"command=ping+[world.time+world.tick_lag*world.tick_usage/value]")

client/New()
    ..()
    ping(1)


When you login you receive the error "Unrecognized or inaccessible verb: ping" but when you try to run it via Command, it works as expected.
Dec 28 2016, 3:32 pm
This is inadequate for a bug report. At the very least you need a code snippet.
Dec 28 2016, 3:37 pm
In response to Lummox JR
Edited the main post.
Dec 28 2016, 3:39 pm
I don't think the verb being hidden is a problem. I think the issue is that you call it immediately from client/New(), but winsets and verbs aren't guaranteed to be valid till Login().
Dec 28 2016, 3:43 pm
In response to Lummox JR
When I remove the set hidden, it works dandy, so...
Dec 28 2016, 9:17 pm
it happens regardless of call point. I had it running in subsystem on /tg/ and it would just end up spamming invalid/inaccessable verb error messages on the client.
Dec 28 2016, 11:06 pm
I'll take a look at this next week and see what comes up.
Jan 4 2017, 1:05 pm
I tried this out, and discovered two things:

1) There's already a built-in ping command that's being executed instead of this one. That's probably one reason for the issue.

2) If I renamed the client verb to pingme, and also made the appropriate changes to the winset() and made the first call in mob/Login() instead of client/New(), the proc was called as expected with no errors.

Basically I can't verify there's any general problem with hidden client verbs. In fact I tried a simple generic call at first and it went perfectly.

client/verb/HiddenVerb()
    set hidden = 1
    src << "Hidden verb!"
client/verb/CallHiddenVerb()
    HiddenVerb()

I also tried the code that was originally posted, not even changing the client/New() part, and had no problems.

As it stands now, I can't reproduce this issue. I'm not getting an unrecognized command error. If you have a test project that shows this where somehow this snippet alone did not, by all means please send it along.
Jan 4 2017, 1:05 pm
Lummox JR changed status to 'Unverified'
Jan 4 2017, 1:51 pm (Edited on Jan 4 2017, 1:59 pm)
oh. this bug!

Try update_ping for the name. (or anything with ping in it on it's own "word" since _ is treated as a space)

(hint: ID:2145878)