[Webclient] Buggy flick()

ID:2060684
 
Mar 27 2016, 7:29 pm
Resolved
Flicks sometimes repeated the first animation frame.
BYOND Version:(apparently) all webclient versions.
Operating System:Windows 10 Pro 64-bit
Web Browser:Chrome 49.0.2623.87
Applies to:Webclient
Status: Resolved (511.1351)
This issue has been resolved.
Descriptive Problem Summary:

It seems that flick() sometimes does not recover elegantly and revert back to its original state. At the end of the animation it briefly shows the first frame of its animation before returning to its normal state.

icon_state = "null" // just a blank state
flick(end_state, src) // plays animation, then goes blank


The following code, in theory, plays an animation of any length and makes src disappear. This USUALLY works, but sometimes you get odd flickering like this:

http://i.imgur.com/jaQLRK3.gifv


This is an issue with, from what I have seen, every single webclient release. The same behavior does not happen with DreamSeeker as far as I can see.
Jul 29 2016, 2:46 am (Edited on Jul 29 2016, 2:52 am)
Still seeing this a lot in the latest release.

Another example, when the dragon hits the ground (this buggy 'flicker' happens 100% of the time): http://i.imgur.com/tg673Yy.gif
Jul 29 2016, 8:50 am
I'll look into getting this fixed alongside the other webclient changes I'll be working on for 511.
Jul 29 2016, 11:43 am
We've actually had a similar issue in ss13 on DS, At least i think we do, i don't know our door code well enough to know if it's our fault or yours, (hence why it hasn't been reported) but it usually involves server lag of some kind or a spike/change in network lag.
Aug 4 2016, 12:51 pm
I've made a simple change to the end-of-flick logic that I think will fix this. Please retest in 511.1351.
Aug 6 2016, 7:54 pm
I'm pretty sure this is fixed in 511.1351. It's kind of hard to tell because every other resource is knackered, but I've yet to see any flickering.
Aug 11 2016, 3:24 am
Yeah, this is all good now. Thanks.
Aug 11 2016, 9:28 am
Lummox JR resolved issue with message:
Flicks sometimes repeated the first animation frame.