spawning mob in same loc of another mob deletes character

ID:1905712
 
Jul 27 2015, 8:41 pm
(See the best response by Kaiochao.)
i can work around this but whats the right way to make it so this doesnt happen.

Jul 27 2015, 8:43 pm
Gonna need to see code. This shouldn't be happening.
Jul 27 2015, 8:45 pm
In response to Ter13
its always happened sense i started my project.

all i do is

player1.loc=move(locate(1,1,1))
player2.loc=move(locate(1,1,1))

to work around this ive done
player1.density=0;player1.loc=move(locate(1,1,1))
player2.density=0;player2.loc=move(locate(1,1,1))
player1.desnity=1;player2.desnity=1

but now that is getting anoying and i want to find the actual problem
Jul 27 2015, 8:48 pm
In response to Ter13
wait a second whie searching all instances of cross i may have come across something. just a minute, its useless code as well
Jul 27 2015, 8:52 pm
In response to Ter13
nope didnt fix it
Jul 27 2015, 8:55 pm
Best response
What is move()? It's not a BYOND proc. You're setting the players' loc variables to the return value of some "move()" proc, so it's possible that the locs are being set to something that isn't a loc.

However, there shouldn't be any deletions happening.
Jul 27 2015, 8:57 pm
Move(NewLoc,Dir=0,step_x=0,step_y=0)

from the byond references. thats the move im using.
Jul 27 2015, 8:59 pm
In response to DanteVFenris
According to the Reference, Move() returns a number. You're setting your players' locs to numbers! What do you make of that?
Jul 27 2015, 9:00 pm
Kaiochao nailed it. You shouldn't be setting loc to the return value of Move() which is 0, 1, or the number of pixels moved in a slide.

player1.density = 0
player1.Move(locate(1,1,1))
player1.density = 1
Jul 27 2015, 9:01 pm
ahh that worked, yea my degree of what ive learnt has changed quite a bit from begining to end. So when i have to work on something earlier it sometimes is done weirder. Just changing the loc to my desired location and not using move fixed everything
Jul 27 2015, 9:02 pm
In response to Ter13
oh okay i havent used move in a long time but i thought it moved to a location. but thanks guys appreciate it!
Jul 27 2015, 9:05 pm
In response to Ter13
now that thats done, all my social features are not broken. Like you can still duel and add your enemy to your party while doing a pvp areana type thing but meh its not going to hurt anyone if i ignore it.
Jul 27 2015, 9:10 pm
In response to DanteVFenris
movable.Move(Location) moves movable to Location. If successful, movable.loc equals Location afterwards, and the entire statement movable.Move(Location) is seen as a positive number.

movable.loc = movable.Move(Location) sets movable.loc to movable.Move(Location), which, after successfully doing the move, is seen as a positive number.

player1.loc = player1.Move(locate(1, 1, 1))

// on success, that line becomes
player1.loc = 1

// on fail, it becomes
player1.loc = 0

// this is what you did, but neither is what you want

That is how the return value of procs works. It's the same as in this example:
mob
    Login()
        src << Poop()

    proc
        Poop()
            return "poop"

That line, src << Poop(), becomes src << "poop" after Poop() returns.
Jul 27 2015, 9:18 pm (Edited on Jul 27 2015, 9:28 pm)
Alternately, you can use a proc I'm quite fond of: ForceMove()

It completely ignores density and Enter()/Exit() functions and just calls Exited()/Entered()

atom/movable
    proc
        ForceMove(atom/NewLoc,Dir=0,Step_x=0,Step_y=0)
            var/list/oloc
            if(loc&&isturf(loc))
                oloc = obounds(src)
            var/ol = loc
            loc = NewLoc
            step_x = Step_x
            step_y = Step_y
            if(Dir) dir = Dir
            var/list/nloc
            var/list/cloc
            if(loc&&isturf(loc))
                nloc = obounds(src)
                if(oloc)
                    cloc = oloc - nloc
                else
                    cloc = nloc
            var/atom/o
            if(oloc)
                for(var/turf/t in oloc)
                    t.Exited(src,loc)
                for(var/atom/movable/o in oloc)
                    o.Uncrossed(src)
            else if(ol)
                o = ol
                o.Exited(src,loc)
            if(cloc)
                for(var/turf/t in cloc)
                    t.Entered(src,ol)
                for(var/atom/movable/o in cloc)
                    t.Crossed(src)
            else if(loc)
                o = loc
                o.Entered(src,ol)