So im rewriting my pet AI. So far it does what i set out to do. However when i change direction i would like it to smoothly walk to a position directly behind the player. Any nice ways of doing that? right now it just changes it location to be behind the player
Although you're intentions are true, this is a terrible way to go about this.
First off, you should be reducing the amount of variables from 3 (tx, ty, tz) to one associated list variable instead. Like last_location["x"] = target.x Secondly, you should be "summoning" pets via Move(), and not directly setting their x, y, and z unless Move() fails (but if Move() fails, you should be checking why, whether the location they plan to teleport to is already occupied, or it's a dense location that pets shouldn't be on anyways (roofs, boulders, etc).) Thirdly, you shouldn't need an infinite loop to move your pet. Change the pet location via the player's movement procedure, not a loop (regardless of whether you've set it to a background process or not). This will reduce the amount of calls and overhead since you only need to move the pet when the player moves, you don't need to check locations every tick. Fourthly, this won't work like you plan on it working:
spawn(10)target=locate(/mob/player)
I can photobomb your pet and steal it if I was playing. This will make the pet's target variable reference to the first /mob/player type it finds. That means there's going to be the chance someone can jump right in when the pet is summoned via New() and steal it. Finally, don't use goto loops. Use while() and for() loops. They're much more pleasing and code-efficient. | |
should be edited to suite your needs. Please don't tell me how to write my own code. This is a simple setup that can be improved, and that's all I intend to provide. No one learns how to stand on their own two feet if your holding them up all the time. | |
Maybe it was because I wasn't using step_to my idea was similair except I didn't use a loop. What I did was when my character moves I also check for a pet. If it has a pet I make the pet move with the player.
Though maybe step_to will make it looks nicer than what I was doing never used it I don't think. Anyway thank you I'll try it out after work | |
IchiroKeisuke wrote:
should be edited to suite your needs. To be fair, "should be edited to suite your needs." and reworked entirely are different things. On that note, the person is more likely to learn if you explain how to do whatever they're asking for, much like Maximus did. Your approach was to give copy/paste code that was "intentionally" poorly made for the sake of "learning". Sabotage and learning don't really go hand-in-hand. | |
Accusing me of sabotage doesn't help anything or anyone, but go ahead if it makes you feel better.
but to clarify, its a rather simple concept. 1)You identify where you want the pet to be at.
tx=target.x2)You have your pet walk to that location. step_to(src,locate(tx,ty,tz)) 3)rinse and repeat when necessary. All in all, there are tons of different ways to solve problems in code. Those snippets could be rewritten in many different ways, and I'm going to leave that part up to Dante to experiment with. Got a better snippet of code? fine, just don't talk to me about how great it is or how terrible my suggestion is. | |
Wouldn't that put the pet over the player? I want it behind which I have.
My main problem is when changing directions let's say from North to west. The pet will just teleport 2 tiles over to do that. Which looks unclean. My main question was how do I make pets have a smooth transition when walking all directions. Not just have them teleport behind you | |
You'll want to use Enter() in this case.
Grab the old-location, and have the pet walk_to() or step_to() or whatever your movement method is. Modify the turf's Enter() to grab the atom/oldloc param and send that to the pet as the target location to walk to. Or save the player's last-location and have the pet reference that. //corrected | |
You can get the tile behind a player at any instant with: get_step(player, turn(player.dir, 180)). No verbose logic necessary.
| |
Kaiochao wrote:
You can get the tile behind a player at any instant with: get_step(player, turn(player.dir, 180)). No verbose logic necessary. this. the turn proc didn't even occur to me. :( | |
https://www.youtube.com/watch?v=1ZIfcUvHZck
go to 6:36. this is what i want. See what happens when he changes directions | |
If you want your follower to step towards where you were before you moved, it can be as simple as this:
mob/player This is similar to what Maximum_Alex2003 mentioned. | |
it doesnt seem to do as mentioned. Like it does for the south side kinda. it underestimated the south side and overestimates the north. southside it want to go on my tile, north side it want to be an extra tile back for some reason
| |
no no its not doing that. its just by tile when i want by exact pixel. Moving at the last location of the mob is the right idea though. It did help.
oh man i need to experiment more. I want the movement to look identical to that movement in the video. But ill try with this new info it might help get me somewhere | |
If you wanted a pixel movement solution, you should've mentioned that when you posted that tile-based Pokemon demo!
// set to match world.icon_size Untested, but it might work, assuming your follower is non-dense (or at least Cross() lets players and their followers cross over each other, e.g. using the "group" variable). edit: may have fixed a vibration issue, but still untested because phone. | |
Then you have your pet walk to that location.
This might get you started. Although it should be edited to suite your needs.