atom.override crashes DreamDaemon

ID:1876696
 
Jun 18 2015, 2:36 am
Resolved
Using image.override with the webclient could result in a server crash.
BYOND Version:508.1289
Operating System:Windows 7 Ultimate 64-bit
Web Browser:Chrome 43.0.2357.124
Applies to:Dream Daemon
Status: Resolved (508.1290)
This issue has been resolved.
Descriptive Problem Summary:

(Unsure if the problem is related to the webclient or just DreamDaemon so I'll tag this as a DreamDaemon issue)

Every time atom.override is applied to an /image type and output to a client (and only when the client actually sees the image as result of being in proximity) DreamDaemon will crash.

Related code:
The following code will produce a crash:

var/image/override_image = image(icon = 'blank.dmi', loc = generic_mob)
override_image.override = 1
client << override_image


To explain, the intended code has the effect of making something invisible only to certain players. blank.dmi is literally just an icon with a single, blank icon state.

If more information is needed, I'll do my best to provide!

Jun 18 2015, 9:14 am
This would have to be the webclient (although on the server end) because of the fact that the server doesn't handle these situations otherwise. I'll look into it.

DSification will make this moot but that's an ongoing process.
Jun 18 2015, 10:55 am (Edited on Jun 18 2015, 11:11 am)
Although I was unable to reproduce this, I did find that the logic involved was really flawed. I suspect I have a fix for this.

[edit]
This was reproducible using two images: a first non-override, then one that was an override. It's clear to me now that I do have a fix.
Jun 18 2015, 11:11 am
Lummox JR resolved issue with message:
Using image.override with the webclient could result in a server crash.