help with attack code

ID:179873
 
Oct 16 2001, 3:28 pm
sorry if im bothering people with my questions but could you help me with this attack code.

mob/verb/attack(mob/M as mob in oview(1))
usr << "You attack [M]!"
oview() << "[usr] attacks [M]!"
var/damage = rand(1,10)
world << "[damage] damage!"
M.HP -= damage

ive tried a couple things but they didnt work so could anyone get it straightened out for me.
Oct 16 2001, 3:30 pm
Im not sure but shouldnt it be M:HP ?



Sorry if i am wrong
Oct 16 2001, 3:32 pm
In response to Demonic Shoe
no, it still says M/:/HP:bad var.
Oct 16 2001, 3:34 pm
In response to DuDE6688
DuDE6688 wrote:
no, it still says M/:/HP:bad var.



Try doing M.HP instead.
Oct 16 2001, 3:39 pm
In response to Nadrew
thats what it was in the begining
Oct 16 2001, 3:40 pm
In response to DuDE6688
DuDE6688 wrote:
thats what it was in the begining


Ok where do you have the HP var defined?
Oct 16 2001, 3:54 pm
In response to Nadrew
right above the attack code. like this
var
HP = 100
Oct 16 2001, 3:57 pm
In response to DuDE6688
DuDE6688 wrote:
right above the attack code. like this
var
HP = 100


It should be
mob
    var
        HP = 100

The way you have it calls it as a global var.
Oct 16 2001, 4:04 pm
In response to Nadrew
now my death check is is wrong.

proc
DeathCheck()
if (HP <= 0)
world << "We laugh upon [src] for their misfotune."

this is the error

test.dm:24:error:HP:bad var
Oct 16 2001, 4:13 pm
In response to DuDE6688
try src.hp
Oct 16 2001, 4:13 pm
In response to DuDE6688
DuDE6688 wrote:
now my death check is is wrong.

proc
DeathCheck()
if (HP <= 0)
world << "We laugh upon [src] for their misfotune."

this is the error

test.dm:24:error:HP:bad var


if(src.HP<=0)

because the HP var is set for certain mobs.
Oct 16 2001, 4:41 pm
In response to Nebathemonk
Nebathemonk wrote:
try src.hp

it still dosent work
Oct 16 2001, 4:49 pm
In response to Nadrew
Nadrew wrote:
if(src.HP<=0)

because the HP var is set for certain mobs.

The call as it is now would equate to src.HP anyway, so this wouldn't change a blessed thing.

Lummox JR
Oct 16 2001, 4:51 pm
In response to DuDE6688
DuDE6688 wrote:
now my death check is is wrong.

proc
DeathCheck()
if (HP <= 0)
world << "We laugh upon [src] for their misfotune."

this is the error

test.dm:24:error:HP:bad var

Strikes me that this is the same problem as the one Nadrew pointed out: The proc is probably global, and so there's no mob with HP to refer to. Make sure this proc block is inside your mob's code, not outside. If you have further problems, please post the entire source (or a big segment, anyway, with the relevant parts) so we can see what exactly is where.

Lummox JR
Oct 16 2001, 5:00 pm
In response to Lummox JR
Lummox JR wrote:
DuDE6688 wrote:
now my death check is is wrong.

proc
DeathCheck()
if (HP <= 0)
world << "We laugh upon [src] for their misfotune."

this is the error

test.dm:24:error:HP:bad var

Strikes me that this is the same problem as the one Nadrew pointed out: The proc is probably global, and so there's no mob with HP to refer to. Make sure this proc block is inside your mob's code, not outside. If you have further problems, please post the entire source (or a big segment, anyway, with the relevant parts) so we can see what exactly is where.

Lummox JR


That was the only thing I was wrong is that he was using a global var for a certain mob so I had him change it to be for individual mob then he was still trying to use a global var in his Deathcheck proc so I asked him to change that to
work with single mobs too it may not work how I put it because I had no clue of how he had other things coded I was just giving him a idea of how to fix it not the exact soulution.
Oct 16 2001, 5:02 pm
In response to Lummox JR
ok heres about all of my coding except turfs and save file

one file
mob/verb/say (msg as text)
world << "[usr]: [msg]"


mob/verb/attack(mob/M as mob in oview(1))
if (M.HP <= 0)
usr << "[M] has already been dealt with."
else
usr << "You thrust your weapon at [M]!"
oview() << "[usr] thrusts at [M]!"
var/damage = rand(1,10)
world << "You take [damage] point damage!"
M.HP -= damage

proc
DeathCheck()
if (M.HP <= 0)
world << "We laugh upon [src] for their misfotune."


second file
/mob/hovercraft
icon = 'hover bot.dmi'
density = 0
/mob/fighterbot
icon = 'mobil fighter1.dmi'
mob
var
HP = 100
Oct 16 2001, 5:09 pm
In response to DuDE6688
DuDE6688 wrote:
ok heres about all of my coding except turfs and save file

one file
mob/verb/say (msg as text)
world << "[usr]: [msg]"


mob/verb/attack(mob/M as mob in oview(1))
if (M.HP <= 0)
usr << "[M] has already been dealt with."
else
usr << "You thrust your weapon at [M]!"
oview() << "[usr] thrusts at [M]!"
var/damage = rand(1,10)
world << "You take [damage] point damage!"
M.HP -= damage

proc
DeathCheck()
if (M.HP <= 0)
world << "We laugh upon [src] for their misfotune."

You must define M in this proc because it is not defined here and only in the Attack verb you could change M to usr and call it like this in the attack verb DeathCheck(M).
Oct 17 2001, 3:38 am
In response to Nadrew
Nadrew wrote:
That was the only thing I was wrong is that he was using a global var for a certain mob so I had him change it to be for individual mob then he was still trying to use a global var in his Deathcheck proc so I asked him to change that to
work with single mobs too it may not work how I put it because I had no clue of how he had other things coded I was just giving him a idea of how to fix it not the exact soulution.

My brain has the consistency of pudding right now, which means it's impossible to read run-on sentences. Please use some punctuation so I can follow what the heck you're saying.

Lummox JR
Oct 17 2001, 3:40 am
In response to DuDE6688
DuDE6688 wrote:
mob/verb/say (msg as text)
world << "[usr]: [msg]"

mob/verb/attack(mob/M as mob in oview(1))
if (M.HP <= 0)
usr << "[M] has already been dealt with."
else
usr << "You thrust your weapon at [M]!"
oview() << "[usr] thrusts at [M]!"
var/damage = rand(1,10)
world << "You take [damage] point damage!"
M.HP -= damage

proc
DeathCheck()
if (M.HP <= 0)
world << "We laugh upon [src] for their misfotune."

Yep, there's the problem right there. As I suspected, you have proc/DeathCheck() defined globally; it doesn't go with a mob. To match the rest of your code, change proc to mob/proc and it should be fine.

Lummox JR