Movables with bound_height/width higher than icon size messes up Move()

ID:1774978
 
Jan 31 2015, 8:05 pm
BYOND Version:507
Operating System:Windows 7 Pro
Web Browser:Firefox 31.0
Applies to:Dream Daemon
Status: Open
Issue hasn't been assigned a status value.
Test case: http://puu.sh/fjvpn/ee1e722c1d.7z
Have a mob or any movable with bound_height and bound_width set to 64 and override the Move() proc and see as newLoc is always equal to your current location.
Jan 31 2015, 10:18 pm
Yes a flaw in my code makes the server pass the current location as the new location to Move()

I just grabbed a shitty tutorial off the hub because i'm too lazy to make up a small test case of my own, my only changes are
/mob/player/Move(newLoc,Dir=0,step_x=0,step_y=0)
    if(loc == newLoc)
        world << "<font color='red'>\[MOB\]Current location and newLoc are equal.</font>"
    else if(!newLoc)
        world << "<font color='red'>\[MOB\]we were passed a null newLoc!</font>"
    return ..()
/atom/movable/Move(newLoc,Dir=0,step_x=0,step_y=0) 
    world << "[src] moving - \ref[loc]([loc]) | \ref[newLoc]"
    if(!loc || !newLoc)
        world << "no loc or newLoc"
        return ..()
    var/atom/oldloc = loc

    if(loc != newLoc)
        if (!(Dir & (Dir - 1))) //Cardinal move
            . = ..()
            world << "cardinal move ( [.] )"
        else //Diagonal move, split it into cardinal moves
            world << "diagonal move"
            if (Dir & 1)
                if (Dir & 4)
                    if (step(src, NORTH))
                        . = step(src, EAST)
                    else if (step(src, EAST))
                        . = step(src, NORTH)
                else if (Dir & 8)
                    if (step(src, NORTH))
                        . = step(src, WEST)
                    else if (step(src, WEST))
                        . = step(src, NORTH)
            else if (Dir & 2)
                if (Dir & 4)
                    if (step(src, SOUTH))
                        . = step(src, EAST)
                    else if (step(src, EAST))
                        . = step(src, SOUTH)
                else if (Dir & 8)
                    if (step(src, SOUTH))
                        . = step(src, WEST)
                    else if (step(src, WEST))
                        . = step(src, SOUTH)
            world << "(diagonal finished)"
    else
        world << "Our origin - \ref[loc]([loc]) - is equal to our destination - \ref[newLoc]([newLoc])"


    if(!loc || (loc == oldloc && oldloc != newLoc))
        world << "We didn't go anywhere...\ref[loc]([loc]) is equal to \ref[oldloc]([oldloc])"
        return
    world << "We did [.] pixels of movement"
    return .

and
        bound_height = 64
        bound_width = 64
Feb 1 2015, 7:04 am
Cloud Magic wrote:
I don't think this is a bug; I think it's a flaw in your code.

Can we get this post removed, its low effort trolling spam.

Posting guidelines wrote:
"Trolling" is posting with the intention of inciting a user or group, or otherwise getting a reaction that contributes nothing but negative energy to the discussion.

I don't see anything positive coming of a post that blindly claims a bug report is the result of bad code.