Ek! =(

ID:175772
 
Mar 12 2003, 2:30 pm
I feel somewhat uncomfortable posting this, but what do you think the most efficient way to do a worlds repop is? Show me the code which you think is most efficient. I've brain stormed everyway possible I can think of, and so far this is most effective:
/proc/Rep()
    spawn()
        while(1)
            sleep(962)
            world.Repop()
            sleep(3)
            for(var/obj/blood/O in world)del O
            sleep(3)
            for(var/obj/blood1/O in world)del O
            sleep(3)
            for(var/obj/blood2/O in world)del O
            sleep(3)
            world<<"<B><font size=1><font color=blue>Kami <font color=red>waves his hand over the earth, restoring it's natural beauty."

world
    New()
        var/savefile/F = new("bank_accounts.sav")
        F["stuff"] >> accounts
        if(accounts == null)
            accounts = list()
        var/savefile/A = new("donaters.sav")
        A["stuff1"] >> donaters
        S_slof=new/list
        if(Scg)Lag_Guard()
        Rep()


That code there reduces the amount of times the game has a "nervous breakdown", meaning, the verbs lock up. This has happened a long time and I know the repop code is causing it. This seems to be the most effective way I can think of, but maybe you know a better way. Please post what you think could be wrong, or a new way of doing it. I might have already done it that way, but suggestions are always good :)


RaeKwon
Mar 12 2003, 3:46 pm
I think handling repop is best suited to doing it manually. Move any mobs you want to keep (non-unique mobs, for example) into the contents of a holder object. Then, when it comes time to repop, handle it from that object. If you want to, for example, respawn something only once per two cycles, then simply move everything back that has a cycle var set to the cycleneed var (after incrementing cycle by one). If you want something to be respawned exactly X seconds after it's "deleted," then customize the Entered() proc for the holder object.
Mar 12 2003, 3:51 pm
In response to Garthor
 
proc/Rep()
    spawn(962)
        world.Repop()
        spawn(3)for(var/obj/bloods/O in world)del O
        spawn(3)world<<"<B><font size=1><font color=blue>Kami <font color=red>waves his hand over the earth, restoring it's natural beauty."
        spawn() Rep()
world
    New()
        var/savefile/F = new("bank_accounts.sav")
        F["stuff"] >> accounts
        if(accounts == null)
            accounts = list()
        var/savefile/A = new("donaters.sav")
        A["stuff1"] >> donaters
        S_slof=new/list
        if(Scg)Lag_Guard()
        Rep()


I guess is the best way to go. Agree?

RaeKwon
Mar 12 2003, 7:54 pm
In response to RaeKwon
Actually, what I think is doing it is the blood removal, not the repopulation... Looping through everything in the world to find if it is a blood object is probably causing the trouble...

I had an instance in DBTC where I was looping through just one certain type of turf in the world, and changing their icon_states... There were probably less than a few dozen of these turfs in the game, yet it ended up tripping the loop check... Most likely because to find those turfs, it looped through every single turf in the game to hunt them down... Same thing with objects... I'd imagine that Zeta has quite a few objects, especially if blood splatters are being created (at least that's what I assume you're doing...I haven't played Zeta enough to know...lol)

What I think would be the best way to fix it is this:

Instead of deleting the blood objects in the repop proc, override their New() proc to delete them a certain time after they're created...

obj/blood(1)(2)
New()
..()
sleep(600) // does it really need to be longer than a minute?
del(src)

Of course, that ruins the sentiment of Kami restoring the world, and cleaning up all of the blood...since it'll happen at different times than the repop... But I think it'll solve the problem, and that would seem to be worth it...