maptext in web client is inconsistent with Dreamseeker

Page: 1 2
ID:1668518
 
Aug 28 2014, 9:41 pm
Resolved
Maptext wasn't rendering at the correct size in the webclient. Additionally, Dream Seeker also rendered maptext sizes inconsistently.
BYOND Version:507
Operating System:Windows 7 Home Premium 64-bit
Web Browser:Firefox 31.0
Applies to:Webclient
Status: Resolved (507.1260)
This issue has been resolved.
Descriptive Problem Summary:
Maptext size is inconsistent in the webclient (though it seems generally smaller than in the dreamseeker).

Screenshot of game in dreamseeker: http://puu.sh/bcpD1/c24712b12a.png
Screenshot of game in webclient: http://puu.sh/bcpOB/b1c763654d.png

Numbered Steps to Reproduce Problem:
Create an atom with maptext. Set the maptext size using a < font > tag.

Code Snippet (if applicable) to Reproduce Problem:
atom.maptext = "<font size = 0.5> asdf </font>"


Expected Results:
maptext in the dreamseeker and the webclient are somewhat consistent.

Actual Results:
Size of maptext in the webclient is inconsistent and generally unreadable.

Does the problem occur:
Every time? Or how often? Every time
In other games? Yes
In other user accounts? Seems irrelevant
On other computers? Untested

When does the problem NOT occur?
Never

Did the problem NOT occur in any earlier versions? If so, what was the last version that worked? (Visit http://www.byond.com/download/build to download old versions for testing.)
Not applicable

Workarounds:
Use dmifonts.
Aug 28 2014, 9:45 pm
I'll have to check if we are properly mapping all font formats, but you may try specifically using the px format which I believe is the one we translate to natively. I swear I tested all of this but might not have checked the obvious "default" format.
Aug 28 2014, 10:28 pm
Chrome exhibits the same behavior with maptext in the webclient. Drawn font sizes in Chrome seem to be exactly the same as those in Firefox.
Aug 28 2014, 10:29 pm
Did you try outputting in different font formats (mainly px or pt)?
Aug 28 2014, 10:30 pm
Not yet, will get to that next.
Aug 29 2014, 1:37 am (Edited on Aug 29 2014, 2:16 am)
I just finished converting between html font tags to css spans for the maptext so that I could test with different font formats.

In the game, the standard font size is 10pt. The smaller size is 8pt, and the larger size is 14pt.

Here are my results:
Dream Seeker - http://puu.sh/bczd3/7647a5beee.png
Webclient - http://puu.sh/bczgg/df947f1490.png
Aug 29 2014, 6:23 am
This might be a problem with how we're choosing the default maptext size. That's taken from the map control itself, which would normally be exactly your default size without changes, if you didn't specify. We might need to include some logic to make it a certain size when not specified, at least in translated skins.
Aug 30 2014, 5:11 am
You probably shouldn't be using a deprecated tag like font.
Aug 30 2014, 6:34 am
In response to EnigmaticGallivanter
EnigmaticGallivanter wrote:
You probably shouldn't be using a deprecated tag like font.

Don't be a poop. Read my latest comment; I changed the font tags to spans and am still getting the same problem.
Aug 30 2014, 9:53 am
We're translating the font tag anyway, so that's not really the issue. Basically DS has a different way of calculating the default size and we want to bring the webclient more in line with expectations.
Aug 30 2014, 1:06 pm
Tom resolved issue with message:
Text size wasn't rendering properly in the webclient.
Sep 16 2014, 5:22 am
I'm still seeing issues with this. The left side is the webclient and the right is DS.


Demo
Sep 16 2014, 6:48 am
That's a different font, which would account for some of it. The one on the right is the system font MS Sans Serif. The webclient default is to use whatever sans-serif the browser normally uses.
Sep 16 2014, 7:34 am


That should be 12pt Comic Sans MS in both of them.
    O.maptext = "<div style='font-size:12pt; font-family:\"Comic Sans MS\"; color:#ff6;'>This should display the same in DS or the webclient</div>"


EDIT: Tested in IE and Chrome and the web client displays the same in both.
Sep 16 2014, 7:52 am
Okay, good to know. With the same font I wouldn't expect a size difference like that. Oddly though I'm wondering if DS isn't the one in the wrong.
Sep 16 2014, 5:34 pm
I will test this out, but to help, can you tell me which font seems more accurate, eg, when comparing to a web-page rendering that same font? My gut feeling is that DS is rendering incorrectly (which would be better IMO if the goal is to faze that out).
Sep 16 2014, 8:35 pm
Seems that DS is correct.
This:
<html>
<body>
<div style='font-size:12pt; display: table-cell; vertical-align:bottom; height: 128px; width:128px; background: url(mtback.png); font-family:"Comic Sans MS"; color:#ff6;'>This should display the same in DS or the webclient</div>
</body>
</html>


produces this which looks just like the DS version above, at least in Chrome on my system.
Sep 16 2014, 10:10 pm
Ok! We will figure it out.
Sep 17 2014, 4:43 am
Off topic, but that HUD is absolutely gorgeous.
Sep 17 2014, 11:43 am
On further investigation, I believe this is actually DS's fault.

DS appears to be routinely setting a positive value for lfHeight in its LOGFONT struct for the map, when a negative value is actually correct. (The output control has a whole other behavior because of the way it uses a rich text control, but I'm not too concerned about making sure it conforms.) Correcting this erases the discrepancy between DS and the webclient, and text metrics are lining up perfectly.
Page: 1 2