How-To Harry Potter Marauder's Map

BYOND Forums

Announcements · BYOND Help · Bug Reports · Feature Requests · Beta Testers · Beta Bugs · Developer Help · Design Philosophy · Demos & Libraries · Tutorials & Snippets · Art & Sound · Classified Ads · Game Updates · Contests & Events · Linux Talk · On Topic · Off Topic

ID:158225 Oct 5 2009, 3:39 pm
Gregs	Hey. I'm trying to make a Marauder's Map. There's one in Hogwarts: A History. I can't seem to figure out how to get it to work right. Could anyone point me in the right direction? Or show me a segment of a code that would help me? I need it to give the person's name and their location. Please, any help would be nice.

Oct 5 2009, 3:44 pm
Calus CoRPS	Gregs wrote: Hey. I'm trying to make a Marauder's Map. There's one in Hogwarts: A History. I can't seem to figure out how to get it to work right. Could anyone point me in the right direction? Or show me a segment of a code that would help me? I need it to give the person's name and their location. Please, any help would be nice. Do you mind explaining what a "Marauder's Map" is?

Oct 5 2009, 3:57 pm In response to Calus CoRPS
Tsfreaks	http://www.youtube.com/watch?v=9G_SdCcYFJw I also thought about applying this concept as a game. It was a pretty cool idea coming from what's her face. ts

Oct 5 2009, 4:39 pm

In response to Calus CoRPS

Gregs

Calus CoRPS wrote:

Gregs wrote:

Hey. I'm trying to make a Marauder's Map. There's one in Hogwarts: A History. I can't seem to figure out how to get it to work right. Could anyone point me in the right direction? Or show me a segment of a code that would help me? I need it to give the person's name and their location. Please, any help would be nice.

Do you mind explaining what a "Marauder's Map" is?
A "Marauder's Map" is a map that reveals everyone's location throughout the whole game. Like say someone is in Hogwarts Library. It would say "Person" Hogwarts Library 123,412. It doesn't need the co-ordinates but at least their location. Or something i could work with.

Oct 5 2009, 8:26 pm In response to Gregs
Garthor	for(var/client/C) src << "[C.mob]: [C.mob.loc.loc], ([C.mob.x], [C.mob.y], [C.mob.z]" Display however you wish, and assuming you have named areas (which is what C.mob.loc.loc is grabbing).

Oct 5 2009, 8:54 pm In response to Garthor
Schnitzelnagler	Garthor wrote: for(var/client/C) src << "[C.mob]: [isturf(C.mob.loc) ? C.mob.loc.loc : "Somewhere special"], ([C.mob.x], [C.mob.y], [C.mob.z]" I'd advice on making sure not to generate a runtime error here, if I may, since you might get flooded rather fast if you have a hundred players on-line, of which some might be 'in the void (null)'.

Oct 5 2009, 9:39 pm

In response to Schnitzelnagler

Garthor

Schnitzelnagler wrote:

Garthor wrote:

for(var/client/C)
>   src << "[C.mob]: [isturf(C.mob.loc) ? C.mob.loc.loc : "Somewhere special"], ([C.mob.x], [C.mob.y], [C.mob.z]"

I'd advice on making sure not to generate a runtime error here, if I may, since you might get flooded rather fast if you have a hundred players on-line, of which some might be 'in the void (null)'.

I left that as a learning experience.

Oct 8 2009, 1:38 am In response to Garthor
Gregs	Thanks :).

Oct 8 2009, 11:27 am

In response to Schnitzelnagler

Gregs

Schnitzelnagler wrote:

Garthor wrote:

for(var/client/C)
>   src << "[C.mob]: [isturf(C.mob.loc) ? C.mob.loc.loc : "Somewhere special"], ([C.mob.x], [C.mob.y], [C.mob.z]"

I'd advice on making sure not to generate a runtime error here, if I may, since you might get flooded rather fast if you have a hundred players on-line, of which some might be 'in the void (null)'.
Im getting errors.

runtime error: Cannot read null.mob
proc name: Read (/obj/Marauders_Map/verb/read)
  source file: verbs.dm,76
  usr: the gg (/mob/You/Player)
  src: Marauders Map (/obj/Marauders_Map)
  call stack:
Marauders Map (/obj/Marauders_Map): Read()
Gregs (/client): BanCheck(null, "Gregs")
Gregs (/client): New()

Oct 8 2009, 11:45 am

In response to Gregs

Gregs

So. I'm trying to implement a item in the game kind of like the Marauder's Map from Harry Potter. And what the map does is, tells people location. Now, I kind of have any idea for the code and its:

obj
    Marauders_Map
        icon = 'scrolls.dmi'
        icon_state = "blank"
        dontsave = 1
        wlable = 1
        var
            content
            client/C
        verb
            read()
                set name = "Read"
                for(var/client/C)
                src << "[C.mob]: [isturf(C.mob.loc) ? C.mob.loc.loc : "Somewhere special"]"
            Take()
                set src in oview(1)
                view()<<"[usr] takes the [src]"
                Move(usr)
            Drop()
                Move(usr.loc)
                view()<<"[usr] drops their [src]"

>So. I got that all good and every. Click compile. Everything turns up clean. BUT. When i click "read" in the game. I get this:

runtime error: Cannot read null.mob
proc name: Read (/obj/Marauders_Map/verb/read)
  source file: verbs.dm,76
  usr: the gg (/mob/You/Player)
  src: Marauders Map (/obj/Marauders_Map)
  call stack:
Marauders Map (/obj/Marauders_Map): Read()
Gregs (/client): BanCheck(null, "Gregs")
Gregs (/client): New()

>What am i doing wrong??

Oct 8 2009, 12:36 pm

In response to Gregs

Lyndonarmitage1

Not entirely sure that this is what you are looking for but it seems like you are trying to display the area that people are in.
The following should do it:

proc/get_area(var/area/a)
    if(istype(a)) return a
    while(!istype(a))
        a = a.loc
    return a

obj
    Marauders_Map
        icon = 'scrolls.dmi'
        icon_state = "blank"
        dontsave = 1
        wlable = 1
        verb
            read()
                set name = "Read"
                for(var/mob/M in world)
                    if(M.client && M.loc)
                        var/area/location = get_area(M)
                        usr << "[M]: [location.name]"
            Take()
                set src in oview(1)
                view()<<"[usr] takes the [src]"
                Move(usr)
            Drop()
                Move(usr.loc)
                view()<<"[usr] drops their [src]"

Oct 8 2009, 2:06 pm In response to Lyndonarmitage1
Garthor	Why would you take my entirely reasonable format of looping through clients and replace it with the utterly boneheaded format of looping through mobs looking for ones with clients?

Oct 8 2009, 2:07 pm In response to Gregs
Garthor	What you are doing wrong is indentation, and then declaring a client/C variable for the obj instead of fixing THAT error.

Oct 9 2009, 1:32 am In response to Garthor
Gregs	Garthor wrote: Why would you take my entirely reasonable format of looping through clients and replace it with the utterly boneheaded format of looping through mobs looking for ones with clients? Well yours gave me a proc error when i read it in game. So if you tell me how to fix it. I would be more then glad to use yours.

Oct 9 2009, 2:07 am In response to Gregs
Megelic	It's not just about "Fixing it" it's about doing it correctly.

Oct 9 2009, 2:25 am In response to Gregs
Kaioken	He already told you the problem: [link] Compare your code to the for() loop in Garthor's initial example in this thread.

Oct 9 2009, 8:27 pm In response to Kaioken
Schnitzelnagler	Kaioken wrote: Compare your code to the for() loop in Garthor's initial example in this thread. And better yet, try to understand instead of simply copy and pasting.