> //...
>

What is the method that your suggesting?

EDIT:: You're method would work, but you can also do list("[test1]" = 3,"[test2]" = 1) if you're more used to associative lists.
Returns:: Codes\S. Skills - SkillTree.dm:557:error: : expected a constant expression

mob/human/proc
        HasSkill(skillType)
            return (locate(skillType)!=null)

So you reckon just dump the ID var, and use skilltypes directly?. (also means dumping the const vars). And what method would you suggest for some form of quickhand so that when defining a large amount it could be easily found (similar to that of const where i can just Search the source for say.. testskill1 for any reference of it)

When i use this it always appears to return a skill. Which as you stated is a reference to the object.

But it always returns even if they don't have the skill in there skill list. (which is opposite to what you stated it would do)

mob/human/proc
    HassSkill(skillType)
        var/skill/S = locate(skillType) in src.skills
        if(S)
            world << "Located Skilltype."
        else
            world << "Could not Locate"
        return (S!=null)

Repost. With edits to avoid double post spam

i thought it was something like that.

i removed the !=null part of the return as just returning the skill is fine and helps to null another proc. With or without it, it returns the same results or atleast it seems to.

Just another couple of questions they have arisen.

Would you happen to have any thoughts on doing a shorter form for adding the references to lists? if not its cool just curious :p.
As it stands i still use a variable inside the "skilltree" datum so that it knows what skill to add so i have to do /skill/teststuff/testone in that variable to link it. as opposed to the old form (using const vars) TESTONE which would assign a numeric number to it and as such do searching procs to find matching ids.

The next question imposed is i have an Add Skill verb for admins and for debugging purposes that adds a skill i previously could do this just by inputting the numeric ID of the skill and allowing it to run its searches. Now with the removal of Const vars i can no longer do this.. Instead i have to somehow type in the path of the skill.
I find that this could be a hassle and instead tried looking into making a list of all the types so that you can choose it. the list becomes big as you would think and includes all the sub directories such as /skill/fire then /skill/fire/fireball for example. when i don't really need to see /skill or even /skill/fire since there not actual skills naturally.

I also tried just having a "text" input on the verb but typing in the skill name does not get me the skill, while trying to use Locate(). i even tried typing the full path into the text field so /skill/test/testone which also could not locate the skill. but if add the path to a list inside the .dm file it works fine, despite both being outputted the exact same when viewing the list. which kinda stumps me, since im trying to find an efficient way to add skills for debugging purposes without having to do the usual skilltree procedure.

// Associative list where text string of last portion of path = type path
//  eg "Fire_ball" = /skill/elemental/Fire_ball
var/list/skill_paths = list()

// Generate the skill_paths list, seeding it with path "names" and their associated type path value.
proc/prepareSkillPaths()
    var
        finalSlash
        i
        nodeName
        pathName
    
    for(var/path in nulliparae(/skill/))
        pathName = "[path]"
        i=0
        
        // Search the path text string for the last '/'
        do
            finalSlash = i
            i = findtext(pathName, "/", i+1)
        while(i)
        
        // Copy the text after the last '/', which we'll treat as the name
        nodeName = copytext(pathName, finalSlash+1)
        
        // Add the node to the list
        skill_paths[nodeName] = path

world/New()
    ..()
    prepareSkillPaths()



skilltree
    var/list/skillreqs
    
    New()
        // Swap out the text names with the actual paths from the skill_paths list
        for(var/i = 1 to skillreqs.len)
            skillreqs[i] = skill_paths[skillreqs[i]]
        
        .=..()
    
    
    /////////// Test code
    
    
    PathOfTheSamurai
        skillreqs = list("Impale","Bleed")
    
    


skill
    elemental
        Fire_ball
    swordplay
        Impale
        Bleed

mob
    var/skilltree/skillTree = new/skilltree/PathOfTheSamurai()
    Login()
        for(var/A in skillTree.skillreqs)
            world<<"[A] (ispath()=[ispath(A)])"
        world<<"----------"
        for(var/A in skill_paths)
            world<<"[A] = [skill_paths[A]]"
        ..()
        



// Title: Nulliparous Type Paths
// Credit to: Jtgibson
// Contributed by: Jtgibson
// http://www.byond.com/members/Jtgibson/forum?id=232#232

// Returns 1 if the specified parameter is nulliparous, 0 otherwise.
proc/nulliparous(type)
    var/tmp/list/types = typesof(type); return (types.len == 1)


// Returns a list of all of the nulliparous types derived from the
//  given type path (excluding the type itself).
proc/nulliparae(type)
    var/list/types = typesof(type) - type; . = list()
    for(var/nutype in types) if(nulliparous(nutype)) . += nutype