During enter,battle starts?

ID:148477
 
Jan 31 2003, 1:26 am
grass1
icon = null
Entered(mob/M)
if(ismob(M))
var/R = rand(1,20)
if(R == 1)
usr.oldx = usr.x
usr.oldy = usr.y
usr.oldz = usr.z
usr.loc = locate(6,6,2)
usr.icon_state = "vis"
usr.islocked = 1
usr.overlays -= /obj/mobhead
usr.overlays -= /obj/mobhead2
var/mob/S = new/mob/Skeleton
alert(usr,"A level [S.level] [S] appears before you!")
sleep(10)
battle(S)
if(R == 2)
usr.oldx = usr.x
usr.oldy = usr.y
usr.oldz = usr.z
usr.loc = locate(95,6,2)
usr.icon_state = "vis"
usr.islocked = 1
usr.overlays -= /obj/mobhead
usr.overlays -= /obj/mobhead2
var/mob/S = new/mob/Snake
alert(usr,"A level [S.level] [S] appears before you!")
sleep(10)
battle(S)
else
return ..()

Now when i enter sometimes,it randomly starts a battle.and theres no grass1 turfs under me.Whys that?
Jan 31 2003, 6:36 am
Why is usr all over that proc when it should be M instead?

Lummox JR
Jan 31 2003, 11:32 am
In response to Lummox JR
im not good at coding, and unless a guru tells you to, don't take my advice, but shouldn't you use enter not entered?
Jan 31 2003, 11:39 am
In response to KitKate20
KitKate20 wrote:
im not good at coding, and unless a guru tells you to, don't take my advice, but shouldn't you use enter not entered?

No, because Enter() is only for determining if you can or can't enter a turf. Entered() is called after you do enter, which is the correct way to do it.

Lummox JR
Jan 31 2003, 11:39 am
In response to KitKate20
Depends on the situation. In this case, it really wouldn't matter, but it would probably be more efficient to use Enter (from my point of view anyway).
Jan 31 2003, 11:42 am
In response to Lummox JR
but it won't matter in this situation. ^_^

Trust me, I'm doing the same exact thing, only I did use Enter instead of Entered. So bleh =P
Jan 31 2003, 11:43 am
1. Check your world.turf var (I think thats the right var. this var is the default turf when you load up a map)
2. Is grass1.icon supposed to = null? =P
Jan 31 2003, 11:44 am
In response to Lummox JR
Ouch,forgot,NO M ON ENTER,EXIT,ENTERED,OR EXITED!
Jan 31 2003, 11:45 am
In response to Ghaleon
1 its set to grass.
2 yes.
Jan 31 2003, 6:21 pm
In response to Ghaleon
Ghaleon wrote:
but it won't matter in this situation. ^_^

Trust me, I'm doing the same exact thing, only I did use Enter instead of Entered. So bleh =P

I'd say it does matter; modifying Enter() will cause an action to happen before the move is complete, and will even act on simple movement checks. Doing it the wrong way instead of the right way closes doors that aren't necessary to close.

And even though it works for your situation, what's the point of actually advising someone to do it backwardly when they can do it a better way and have more flexibility out of it? That's just unnecessary. Don't go actually telling people to do something they shouldn't be doing, just because it may work in a limited case you're used to.

Lummox JR
Jan 31 2003, 6:42 pm
In response to Lummox JR
huh? wrong topic~?