I don't think that works with decimals. How about using round() instead, and rounding to the nearest 1? If the round()ed number is different from the given number, the given number had a decimal place.

Hey man you know what, thank you for answering. I really appreciate your help. I have another problem. Please help with this one too.

The problem here is that everytime I make a new bag of gold, the last one I made's value is now all the others values as well.

Ok Crispy here you go, I tried to check for 0 gold and negative gold.

I'm kinda still in the process of learning DM, even though I've been learning it for almost 2 years now "5 months knowing what I'm doing."

Okay, I'm confused. Where is ammount_to_drop (you misspelt it by the way) defined so that it's accessible in the verb? Why have you defined it on /objs? Where does the gold actually get its amount set? What var does the gold use to hold its var?

Please post everything related to /obj/gold, and show all the bits where you've defined ammount_to_drop.

One of your variable definitions goes like this:



This variable would be an object -- an obj, specifically. Initializing an object to 0 makes no sense. Really, that whole variable makes no sense. =P



Why define ammount_to_drop under /obj/gold? Instead, it should be defined within the drop verb since it is only to be used within the drop verb:



Notice the "as num" there. You want the player to give you a number -- not a string. =)

Well, the snippet should work at this point, but there are a few parts that can be improved:



If you round() ammount_to_drop, then that if(ammount_to_drop % 1 != 0) check isn't necessary -- round(ammount_to_drop) will round ammount_to_drop to the next integer anyway.



If you want to check for an amount of 0 gold, then you should change the above snippet to this:

You're using a GLOBAL /obj variable, set to a number.

Next, why do you have drop_gold() and drop()? drop()'s code apparently is only for gold, since it actually used the word "gold" in it's strings.

If you're going to use a 'set src = usr' verb, which is what /mob/verb/drop_gold is, you should use 'src' in stead of 'usr'. There are rare cases where 'usr' would be wanted, but not here!

Let's take a look at this:

Don't you see what you're doing here? You're declaring a new prototype! /obj/gold/ammount_to_drop!

Back to that global variable. Why is it global, and why is it casted as /obj? Using a global variable is very dangerous, especially for multi-threaded programs! So sleep(), and spawn will be very dangerous. (Again, local variables are the way to go!)

DragonMasterGod wrote:

Thanks for the help wizkid, but I need to fix what the problem is. The problem is that everytime I drop gold bags, the last value of the gold bag that I dropped is now the value of all the gold bags. Look.

While Wizkidd's advice doesn't appear to directly relate to your problem, you should still consider it and follow it. Firstly because it will improve your code, which is always good; and secondly because once some errors are pointed out, the causes behind other errors become apparent.

when picking up objects from the floor, I need this var so that it belongs to the object, so I can check if the object being picked up has this variable

Firstly, you haven't defined that as a var; it needs a "var/" before it. Secondly, you're getting rather confused about what you're doing. Let me explain:

What you're doing is defining a global var called ammount_to_drop (it's still misspelt =)). This is bad! Why? Because there's only one "ammount_to_drop" var. Ever. This means that when you're setting that var for one bag of gold, you're setting it for ALL of them!

See the problem now? You're using the same var for multiple gold bags. Each var can only have one value, so every single gold bag has the same value of ammount_to_drop! In other words, every gold bag has the same amount of gold in it. =)

You're also using the same var for asking the player how much gold they want to deposit, and for holding how much gold exists. This is a bit messy; and once we apply the fix to the above problem, it will stop compiling because the global "ammount_to_drop" var will not exist. So we need to change this as well.

So this is what we need to do:

1. Give each gold bag its own var to hold how much gold is in it.

2. Use a different var to store the player's desired drop amount.

Firstly, a little revision on type paths. There is a big difference between these two lines:



The bit before the "var" is the type of object the variable belongs to. The bit after the "var" is the type of object the variable refers to.

In the example above, the first line defines a var called bestfriend that belongs to all mobs. In other words, all mobs have a best friend. (Hooray!) The second line, though, defines only one best friend, and declares it to be a mob. According to the second line, there is only one best friend in the whole entire universe! Just one! A single one! Isn't that sad? =(

So basically what we need to do is swap the "var" and "obj" around, so that the var belongs to all objs.

"But wait!" you cry. "Not all objs need an amount! Only gold does!"

And you are correct in saying that - even if you didn't say it. ;-D So in fact, what we need to do is give it to all /obj/golds.

I'm also going to rename the var, so its name better matches what it's for; and I'm going to give it an initial value of zero. Replace "var/obj/ammount_to_drop" with this line:



See what that's doing? This var belongs to each /obj/gold object, and refers to a number.

Now on to problem #2. This is easy; instead of using the global var, we now use a local var instead. What's a local var? One that's defined in the proc where it's used, that's what:



Notice the "var/" bit; that defines the variable.



This bit (above) is nearly the same, except for the replacement of "ammount_to_drop" (the misspelled global variable) with "amount_to_drop" (the new local variable).

Now, let's look at this line:



Danger, Will Robinson! The second argument there does nothing, because /obj/gold does not take a second argument to New(). In other words; it's useless.

We have two options:
1. Override /obj/gold/New() so that it accepts a second argument and sets its amount var to it, OR
2. Set the amount var in this proc.

#1 is slightly advanced, so I'm sticking with #2 for now.

Firstly, because we're referring to the bag of gold after its creation, we need a var that refers to it. To do so, we just save the return value of new(), like so:



Actually, we can shorten this a bit. Since we've been nice and well-behaved and defined the bagofgold var with its correct type, we can avoid repeating "/obj/gold" after the "new":



...and this will still work, exactly the same.

Now we just need to set the bag of gold's amount var. You know how to set vars, right? =)



Yay! Our bag of gold now contains the correct amount.



The above two lines are the same except for the changing of the var "ammount_to_drop" to "amount_to_drop".

Whew! That was a lot of typing! But we're not quite done yet. Now we need be able to pick the thing up again.

Now that I've gone and defined your amount var under /obj/gold instead of /obj, this snippet won't work, because not all /objs have amount_to_drop:



Slow down cowboy! Don't go reaching for that there amount_to_drop definition. There's a "better" way to do this. =)

A "get" operation is quite different for a bag of gold than it is for a normal obj. Ideally we'd want to specify each operation in a different place. (It may not be clear to you why this is better; that's okay, just go along with it for now.)

Firstly, let's define picking up for normal objs:



I'll leave you to spot the differences from your existing snippet. =) (Hint: There are two.)

And now, through the magic of object-oriented programming, let us define picking up using the same verb in a different place! Drum roll, please...



As well as defining it under /obj, we've defined it under /obj/gold. "Defining it twice? How can we do that?" Actually we can't; I've defined it once, and overridden it once.

Note that I haven't said "obj/gold/verb/get()"; just "obj/gold/get()". Why? Well, trying putting the "verb" bit back in and see what happens when you try to compile. =) They're still the same verb, which means you can't define it twice. What the above snippet does it override an already defined verb.

Confused yet? You should be. ;-) Read it over a few more times and see if it starts to make sense after a while.

So what's left to do? Actually, nothing. We're done (at last)! Yay!

... Well, I really hope that helped, because I spent about an hour typing it up. My apologies for making you read an essay, but hopefully you'll be a better programmer at the end of it all. =D

Thanks for the help man, I really appreciate your time and I did learn a lot from what you just wrote. But now there is another problem.

Now it's saying that src.amount_to_drop is an undefined variable -.-'. I think I know why, it's because the amount_to_drop variable is where the drop_gold() verb is and not where the obj/verb/get() verb is. It's a local verb, so it is only used when that verb is used. Not when the obj/verb/get() verb is used. How can I fix this? Yea, I know, by moving it, but then a course of other problems come into pl

Whoops! My bad. I should have typed "amount", not "amount_to_drop".