Title Screen's "Begin" DblClick function is broken

ID:144770
 
Sep 1 2006, 1:17 pm
PS: I haven't programmed DM in a year or so so yea, I might've messed up on a few things :(

Code:
turf
   TitleScreen
      icon = 'Title Screen.dmi'
      density = 1

turf
   Begin
      icon = 'begin.dmi'
      density = 1
  
     

mob
   Login()
      usr.loc = locate(13,41,3)
      usr << sound('windfall_island.mid')
      
mob     
   var/O = /turf/Begin
   DblClick(O) 
      if(src.key in GMs)
         new/mob/GM()
         usr.verbs += typesof(/mob/GM/verb)
         usr.GM_powers = 1
      if(src.key == "DragonMasterGod")
         new/mob/MegaGM()
         usr.verbs += typesof(/mob/MegaGM/verb)
         usr.GM_powers = 1
      if(src.key in Banned)
         sleep(20)
         usr << "You are banned from this game."
         del usr
      usr.names = "<Your name>" // We don't need this ehe.
      usr.names = input("What is your name?","Character creation - Name")
      usr.name = usr.names //might be?
      ......


Problem description:Why is it that when I try to click the Begin turf, nothing happens. This is a logical error by the way, since it says 0 errors and 0 warnings.

Sep 1 2006, 2:23 pm
 
turf
   Begin
      icon = 'begin.dmi'
      density = 1
      DblClick() 
         usr<<"Click!"
Sep 1 2006, 3:50 pm
Why would you set DblClick() under mob? Why not set it under the turf/Begin?

turf
   Begin
      icon = 'begin.dmi'
      density = 1
      DblClick() 
            if(usr.key in GMs)
                  new/mob/GM()
                  usr.verbs += typesof(/mob/GM/verb)
                  usr.GM_powers = 1
            else if(usr.key == "DragonMasterGod")
                  new/mob/MegaGM()
                  usr.verbs += typesof(/mob/MegaGM/verb)
                  usr.GM_powers = 1
            else if(usr.key in Banned)
                  sleep(20)
                  usr << "You are banned from this game."
                  del usr
            else ..()
            usr.names = "<Your name>" // We don't need this ehe.
            usr.names = input("What is your name?","Character creation - Name")
            usr.name = usr.names //might be?


That should work. :D usr is fine in proc like this since the only thing that will be doing the clicking is the usr.
Sep 2 2006, 8:01 am
In response to Mechanios
Ok I've done that and it works fine, but after that there's yet another problem with this code here:

for(var/M in cuwords)
         while(findtext(usr.names,M))
            usr.names = ""
            usr.names = "<Your name>"
            usr << "Invalid name.  Re-enter one."
            usr.names = input("What is your name?","Character creation - Name")
            usr.name = usr.names
            count++
            if(findtext(usr.names,M) && count >= 4)
               usr << "You have been booted for spamming."
               usr << "[usr.names] \n [usr.key] \nCount: [count]"
               del usr


For some reason, after I make it so that I get booted on purpose to see if the booting works (by entering in a name like "Fag" about 5 times) it deletes and I loose my connection like I'm supposed to, but I get this error now.

runtime error: Cannot read null.names
proc name: Loginin (/proc/Loginin)
usr: null
src: null
call stack:
Loginin()
Begin (9,40,3) (/turf/Begin): DblClick(Begin (9,40,3) (/turf/Begin))

.... wth?
Sep 2 2006, 8:05 am
In response to DragonMasterGod
Just because you delete the player, doesn't mean the process is going to end. That only happens if you delete the process's containing object itself. So here's what happens:
1) You delete the player
2) It loops back
3) Checks if(findtext(usr.names,M))

Wait a second, usr has been deleted! How is it going to check usr.names?

Solution? Break the loop or return the entire process. If you don't know how to do that, loop up "break" and "return".
Sep 2 2006, 8:54 am
In response to DarkCampainger
Hey man, thanks. I guess all the other times that I was using the del key word, it must've been deleting the object itself so I didn't deal with this before. Yea, I know how to use the return and break key words. Thanks all of you again. My problem has been fixed :).