It telling me somthing is rong when it isnt(i think)

ID:144663
 
Oct 3 2006, 8:01 pm
Code:
turf
    Scorpion
        icon = 'scorpion.PNG'
        Click()
            usr.loc=locate(1,1,3)
            sleep(85)
                var/N
                N=input("Is this the fighter that you would like to train and battle with?", "Mortal Kombat Armageddon")in list("Yes","No")
                if("Yes")
                src.loc=locate(1,1,1)


Problem description:
Its beign stupid and telling me i cant have things when they are where they are suppose to be. can somone help me. Here ar ethe errors

Fighter icons\Character icons.dm:9:error:"Yes":value not allowed here
Fighter icons\Character icons.dm:10:error::empty type name (indentation error?)
Fighter icons\Character icons.dm:10:error:src.loc:undefined var
Fighter icons\Character icons.dm:8:error::expected a constant expression

Oct 3 2006, 9:06 pm
You have indentation errors. For one, you indented under sleep. You didn't indent under if("yes").

Another think, if("Yes") isn't accepted because it will always be true. No point in using an if() statement there, then. You need it under a switch() statement, or you need to check a value directly. if("Yes") doesn't check anything.

Use
if(N=="Yes") loc=(1,1,1)
or
switch(N)
if("Yes") loc=(1,1,1)

By the way, just while were on the subject, usr in Click() is the person doing the Click() procedure. src is the atom you click. Y'know, just incase you didn't know. This procedure is making no sense to me, but then, I have no idea how your game works.
Oct 3 2006, 11:11 pm
 
turf
    Scorpion
        icon = 'scorpion.PNG'
        Click()
            usr.loc=locate(1,1,3)
            sleep(85)  //<---Thats Eight and a half seconds you got there mate!
            var/N=input("Is this the fighter that you would like to train and battle with?", "Mortal Kombat Armageddon")in list("Yes","No"))    //Note the extra bracket.
                if("Yes")
                    usr.loc=locate(1,1,1) //usr  not src in this case.  usr is when a player actively does something, it refers to that person. src is for processes etc. Its more broad...
                if("No")
                    //make sure the player gets sent back to make a different choice if they choose no.
Oct 4 2006, 12:21 am
In response to CuriousNeptune
Don't help if you don't know what you're talking about. You do not need to indent under the var/N statement. You need a switch statement there, and you need to get rid of the var/N= bit.
Oct 4 2006, 1:30 am
In response to Jp
Oh yeah ._.

I don't make such mistakes in my coding, so its not something I picked up on to fix :| (i.e. I read var/N= as switch(input without realising)
Oct 5 2006, 6:06 pm
In response to CuriousNeptune
thx
Oct 5 2006, 6:10 pm
In response to CuriousNeptune
Code:
turf
    Scorpion
        icon = 'scorpion.PNG'
        Click()
            usr.loc=locate(1,1,3)
            sleep(85)  //<---Thats Eight and a half seconds you got there mate!
            var/N=input("Is this the fighter that you would like to train and battle with?", "Mortal Kombat Armageddon")in list("Yes","No"))    //Note the extra bracket.
                if("Yes")
                    usr.loc=locate(1,1,40) //usr  not src in this case.  usr is when a player actively does something, it refers to that person. src is for processes etc. Its more broad...
                if("No")
                    usr.loc=locate(1,1,2)


Problem description:

<font color=red>its gving me some more errors with that code u gave me. I edited it to fit my credentials but somthing is wrong now.

Fighter icons\Character icons.dm:7:error: ): expected }
Fighter icons\Character icons.dm:5:error: location of top-most unmatched {

Mortal Kombat Armageddon.dmb - 4 errors, 0 warnings (double-click on an error to jump to it)
Oct 5 2006, 7:33 pm
In response to Dbgtsuperfreak
Why not just use if ( alert() )?

if(alert("Is the fighter that you would like to train and battle with?",,"Yes","No")=="Yes")
   usr.loc=locate(1,1,40)
else usr.loc=locate(1,1,2)
Oct 6 2006, 12:26 pm
 
turf
    Scorpion
        icon = 'scorpion.PNG'
        Click()
            usr.loc=locate(1,1,3)
            sleep(85)
                var/N = input("Is this the fighter that you would like to train and battle with?", "Mortal Kombat Armageddon")in list("Yes","No")
                switch(N)
                    if("Yes")
                        src.loc=locate(1,1,1)
                    if("No")
                        src.loc=locate(1,1,2)