I need help with an attack system!!

ID:144046
 
Apr 15 2007, 12:00 pm
Code:
    verb/Attack(mob/M in oview(1))
        set category = "Battle"
        var/damage = src.str - M.def
        if(M.client)
            M.hp -= damage
            src.Levelup()
            M.Deathcheck(src)
        else
            if(usr.Waiting <= 0)
                M.hp -= damage
                usr.Waiting = 1
                var/waittime = round(usr.Weaponwaitime * 2)
                spawn(waittime)
                usr.Waiting = 0
            src.Levelup()
            M.Deathcheck(src)


Problem description:

When my defense gets higher then the enemy's strenght, they do negative damage. I need help badly, anyone who helps will be greatly appritiated!!
Apr 15 2007, 1:03 pm
 
if(damage <= 0) damage=0

Quite simple.


--Vito
Apr 15 2007, 4:30 pm
In response to Vito Stolidus
Using <= instead of < there is quite useless. =)
Apr 16 2007, 7:34 am
I suggest you use the max() and you can set a minimum damage it has to do. If you always want it to do at least 1 damage then make the max 1.
Apr 17 2007, 12:37 am
In response to CYN
Yeah, probably the best way to set minimum and maximum caps for values is to just use min() and max(), no checks needed.
Apr 18 2007, 3:12 pm
In response to Kaioken
damage = max(damage,0)