Upgrading Weapons...

ID:142664
 
Apr 5 2008, 5:47 am
Code:
mob
        WeaponTechnician
                icon='NPCS.dmi'
                icon_state="Barber"
                HP=99999999999999999999999999999999999999999999999999
                DblClick()
                        alert("Hi, here for a wep upgrade?")
                        var/weplist = list()
                        if(locate(/obj) in usr:contents)
                                for(var/obj/Weapons/O in usr:contents)
                                        weplist += O
                        var/C = input("Pick a Weapon to Upgrade","Upgrade") in weplist + list("Cancel")
                        if(C!= "Cancel")
                                if(alert("Are You sure you wish to upgrade [C]?","[C]","Yes","No") == "Yes")
                                        if(usr.wealth<=1000)
                                                alert("You dont have enough")
                                        else
                                                C.BulletDammage+=5
                                                usr.wealth-=1000
                                                alert("Enjoy the extra strength")


Problem description:

Supposed to upgrade the selected weapons strength by 5, but it comes up 360:error:C.BulletDammage:undefined var, ive added the bulletdammage var to the vars list, and to the weapons themselves....any help?
Apr 5 2008, 5:51 am
The problem is you're defining C as a variable. Not an atom, much less an obj/Weapons.

Meaning you'll have to change this line to the following;

var/obj/Weapons/C = input("Pick a Weapon to Upgrade","Upgrade") in weplist+"Cancel"


You don't need to define "Cancel" as a list; simply adding it as a text string will work.
Apr 5 2008, 6:12 am
In response to Devourer Of Souls
Devourer Of Souls wrote:
You don't need to define "Cancel" as a list; simply adding it as a text string will work.

You don't need to do that either. Use the 'as' clause with the '|' bitwise OR operator to include 'as null' as a valid choice type, which will add a cancel button to the input() box, which when clicked upon will make input() return null. If you want to choose from a list, you can combine the 'as null' with the 'anything' "type" to allow limitless choosing from the list. 
input("x") as anything|null in List