runtime error: Bad file?

ID:142416
 
Jun 4 2008, 5:10 am
Code:
mob/proc/Save()
    src.xx = src.x
    src.yy = src.y
    src.zz = src.z
    src.V = src.verbs
    var/savefile/F = file("Chronicles of...\ Saves \ [src.ckey].gamsav")
    F << src.party
    Write(F)
mob/proc/Auto_Save()
    src.Save()
    spawn(1200)
    src.Auto_Save()
mob/proc/Load()
    if(fexists("Chronicles of...\ Saves \ [src.ckey].gamsav"))
        var/savefile/F  =file("Chronicles of...\ Saves \ [src.ckey].gamsav")
        Read(F)
        F >> src.party
        var/src.party/S
        src.loc = locate(src.xx,src.yy,src.zz)
        for(var/mob/M in src.party)
            M.loc = src.loc
        for(var/stuff in src.V)
            src.verbs += stuff
    else
        src<<"You have no savefile."

Login Code
mob/Login()
    src<< sound('145838_LostGiftTheme2_full.ogg',1)
    alert("Welcome.","","New Game","Load Game")
    if("New Game")
        src.loc = locate(2,2,1)
        src.Save()
        src.Auto_Save()
        src<<"Your game will always save. It will auto-save when you log out."
    if("Load Game")
        src.Load()
        src.Auto_Save()

Problem description:

Jun 4 2008, 7:46 am
Files are automatically found in the environment folder, so all you have to do is "Saves\[ckey].sav".

And a savefile is .sav, not .gamsav.
Jun 4 2008, 8:00 am
In response to Kaiochao
it has to be?
Jun 4 2008, 8:02 am
In response to Choka
I don't know actually, that's what everyone uses and what is in the reference...

The problem could just be the part before "Saves\"
Jun 4 2008, 8:11 am
In response to Kaiochao
the file extention doesnt matter
Jun 4 2008, 8:26 am
In response to Falacy
Ehhh it still dont work.
Jun 4 2008, 10:05 am
Using file() is likely what is causing the error. There's also a major issue where you are creating a file with the name

"Chronicles of... Saves choka.gamsav"

which is really, really, really bad.
Jun 4 2008, 10:15 am
Use / instead of \ in the path. The problem you're seeing is that DM is interpreting "\ " as just " " because the backslash has to be escaped with another backslash.

If you used \\ instead of \ it'd work, but you may as well use / so you don't always have to remember the double backslash.

Lummox JR
Jun 4 2008, 3:05 pm
In response to Lummox JR
Neither work
Jun 4 2008, 8:15 pm
As Garthor said, the problem is most likely due to the fact that you're using the file() proc instead of the /savefile New() proc. In summary:
// Instead of this:
    var/savefile/F = file(x)

// You should do this:
    var/savefile/F = new(x)


Also, the filename, while probably not causing problems here, really is atrocious. As Lummox said, if you're trying to traverse directories there with the slashes, double-escape your \ slashes (\\ instead of \), or simply use /. Also, it's nice to note that not all platforms support spaces in filenames, and while this is likely not a problem on most systems, you probably should cut those out (i.e., why would you want a folder named " Saves " instead of "Saves"?).

On a final note, in your Load() proc, delete this line:
    var/src.party/S

You never use the variable, and I don't even get what you're trying to do there anyways (I don't think that could actually do anything, anyhow, but I dunno what special value src.party has).