New not actually making a NEW object

ID:141817
 
Nov 1 2008, 11:01 am
Code:
proc
    NewVillage(mob/owner)
        var/randomX = rand(1,world.maxx)
        var/randomY = rand(1,world.maxy)
        var/obj/village/NewVillage = new
        NewVillage.loc = locate(randomX,randomY,1)
        for(var/obj/O in oview(NewVillage,0))
            del(O)
        usr.loc = locate(NewVillage.x,NewVillage.y,NewVillage.z)

proc/randomizeMap()
    for(var/turf/T in world)
        var/random = rand(1,100)
        if(random<=8)
        else if(random<=92)
            var/obj/tree/Tr = new(T)
            Tr.icon = Tr.icon
        else
            var/obj/mountains/M = new(T)
            M.icon = M.icon


Problem description:

Whenever I call the newvillage proc, it doesnt create a new village it just moves the old one to the new location.
Nov 1 2008, 11:16 am
Try using the New() proc?
Nov 1 2008, 11:36 am
In response to Mizukouken Ketsu
... 5th line of code:
var/obj/village/NewVillage = new

-------------------------------^ This IS the new.
Nov 1 2008, 11:40 am
In response to KingCold999
Fine... don't listen to me. Minus well not accept anyone else's help either.
Nov 1 2008, 12:12 pm
In response to Mizukouken Ketsu
?
I used New(), thats the problem. When it is suppose to make a New object it just moves the previous one.
And who's minus?
Nov 1 2008, 2:51 pm
Instead of
        var/obj/village/NewVillage = new
        NewVillage.loc = locate(randomX,randomY,1)

See if this makes a difference:
        var/obj/village/NewVillage = new(locate(randomX,randomY,1))
Nov 1 2008, 3:11 pm
In response to Nickr5
Nope, now it stays at 1,1. However, it does delete a random "Tree" icon, so I believe at least part of it is working :D
Nov 1 2008, 3:14 pm (Edited on Nov 1 2008, 3:42 pm)
In response to KingCold999
Have you overwritten the /obj/village/New() proc?
Nov 1 2008, 3:41 pm
In response to Nickr5
ive only overwritten atom/movable/New() and that was this:
    New()
        for(var/atom/movable/A in range(1, loc))
            if(A.autojoining)
                A.AutoJoin()
        ..()
Nov 2 2008, 6:18 am
In response to KingCold999
Sorry for double post, but I found the problem and corrected it. I was using autojoin, and put an autojoin=1 in the wrong place under turf :P
Nov 2 2008, 6:47 am
In response to Nickr5
The New() proc doesn't have a default action.