Tributing Monsters

ID:1402109
 
Oct 19 2013, 10:56 am
(See the best response by Kaiochao.)
Code:
var/list/Monsters_on_Field = list()
var/Monsters_Played = 0
    verb        
        Summon(obj/Cards/C as obj in usr.Hand)
                if(C.Level==5||6)
                    for(var/obj/Cards/A in usr.Monsters_on_Field)
                        var/select = input(A, "What would you like to tribute?", "Tribute Monster") in list(usr.Monsters_on_Field)
                        if(select == "Monster")
                            usr.Monsters_on_Field -= A
                            usr.Monsters_Played --
                            del A
                            usr.Monsters_on_Field += C
                            usr.Monsters_Played ++
                            C.loc = A.loc


Problem description:

What I am trying to do is select a monster on the "field", delete that monster, and summon a monster of a higher level (5 or 6) from the "Hand" (statpanel contents list). For some reason, the input does not show up, and I am getting errors like crazy. Also, the monster does NOT appear on the field from the hand. Can someone help me with this?
Oct 19 2013, 11:16 am
if(C.Level==5||6)

If this was english this would be: If C's level is 5, or if 6.
That comma matters on what this is saying. It is pretty much two if statements: if(C.level==5) or if(6). You should probably have if(C.level==(5||6)), at least I'm pretty sure - technically you could just check if the level is level 5 or higher.

Also, you delete A and then try to read it's location. Try saving it's location before you delete into a var like var/a_loc=A.loc so you can call on it but not depend on A to be there.
Oct 19 2013, 11:29 am
also "input(A" need to be "input(src"

                        var/select = input(src, "What would you like to tribute?", "Tribute Monster") in list(usr.Monsters_on_Field)

Oct 19 2013, 11:50 am
Ah, missed that one.
Oct 19 2013, 1:42 pm
In response to Jittai
C.level==(5||6) is equivalent to C.level == 5, as (5||6) evaluates to 5 (which is the original problem).
Oct 19 2013, 1:51 pm
So it's better to just split it or go for a >= ?
Oct 19 2013, 2:28 pm
In response to Jittai
Best response
There's a huge difference between "x==5 || x==6" and "x>=5", and it really depends on the context and what the creator's actual intentions are. It's not like one is a generally better choice than the other.
Oct 19 2013, 2:35 pm
In this case he seems to be making/mimicing Duel Monsters, only reason I suggested >=.
Oct 19 2013, 4:08 pm
if(C.level in 5 to 6) would work
Oct 19 2013, 8:01 pm
 
if(C.Level in 5 to 6)
                    for(var/obj/Cards/A in usr.Monsters_on_Field)
                        var/a_loc = A.loc
                        var/select = input(src, "What would you like to tribute?", "Tribute Monster") as null | anything in src.Monsters_on_Field
                        if(!select || select == null) return
                        if(select == A)
                            src.Monsters_on_Field -= A
                            src.Monsters_Played --
                            del A
                            src.Monsters_on_Field += C
                            src.Monsters_Played ++
                            Hand.Remove(C)
                            C.dir = usr.dir
                            C.loc = a_loc


I figured it out, although, the input shows up again after I confirm my descision. Any ideas why this is happening?
Oct 19 2013, 8:18 pm
In response to Yucide
Do you know what for() does and why you're using it?
Oct 19 2013, 8:43 pm
It loops, so techincally, I am repeating the input process and that's why I am having my problem?
Oct 22 2013, 1:04 pm
bump