Players experience Lag when around NPC or players..

Page: 1 2 3 4 5
Oct 23 2013, 5:12 pm
In response to Naruto 5292
Naruto 5292 wrote:
hmmm so like...
>       testnpc
>           name= "random guy"
>           icon = 'test.dmi'
>           maxhealth=1000000
>           health = 10000000
>           NPC=1
>           New()
>               ..()
>               ai_check()
>               ..()
>



You need to put a while loop for the New() proc otherwise it will call it once, if no player is in view then the mob will just sit there.

We need the loop to continually check while the mob exists so that it keeps looking to see if any players are within it's area.
Oct 23 2013, 5:14 pm
You may want to use a spawn loop like:
New()
    ..()
    while(src)
        spawn(50)
            ai_check()
        sleep(world.tick_lag)


To help keep from causing a huge cpu spike.
Oct 23 2013, 9:26 pm
In response to Akando5959
That would be better written as:
New()
    ..()
    spawn()
        var/delay = world.tick_lag * 50
        while(1)
            ai_check()
            sleep(delay)
Oct 24 2013, 3:34 am
Was my explanation and examples really that hard to follow?

ai_check() should not be called by the NPC (enemy, monster etc.) and it should definitely not be a constant loop. It should be called by the player whenever they move, this way as you are walking around, it checks for enemies.

var/playercheck is not a mob variable, it is local to the ai_random_wander() proc and should be created like so:
proc/ai_random_wander()
    while(NpcActive)
        var/playercheck = 0
        //then the rest of the code

Placing this variable elsewhere will have undesirable effects.
Oct 24 2013, 4:17 am
ya thats what I did, i added it to the movement code for players. They told me to add it to npc so i was just about to do it..thanks anyways i added it again to the movement
Oct 24 2013, 4:20 am
But wont that cause lag when the player is around lots of NPC..for example when they go into a forest with lots of npc in it won that make them lag?
Oct 24 2013, 4:21 am
In the game, there is a forest where you have to kill lots of npc (there are many npc in that forest) and I was wondering if that could affect the player's movement (lag,crashes, etc)
Oct 24 2013, 4:31 am
There are other ways of activating and deactivating enemy AI.
Oct 24 2013, 5:09 am
YA i LIKE THIS WAY THOUGH, IT IS EASY And SIMPLE... (EASY TO UNDERSTAND AND SIMPLE TO CODE)... SO i WAS WONDERING IF IT WOULD CAUSE LAG? WOULD IT?
Oct 24 2013, 5:09 am
woops, caps was on sorry :(
Oct 24 2013, 5:13 am
In response to Naruto 5292
Naruto 5292 wrote:
YA i LIKE THIS WAY THOUGH, IT IS EASY And SIMPLE... (EASY TO UNDERSTAND AND SIMPLE TO CODE)... SO i WAS WONDERING IF IT WOULD CAUSE LAG? WOULD IT?

Read the post he linked you.

"causing lag" is really just a concern of bad design.
Oct 27 2013, 2:55 pm
well i tried adding the code, it works but the problem is that when one person goes to a npc....the server crashes.. I have tried lots of things to prevent it but it just wouldn't work so i came back here asking for help....
Oct 28 2013, 4:24 am
Your code is badly done, obviously. You probably forgot a sleep() somewhere.
Oct 28 2013, 5:07 am
 
mob
    proc
        ai_random_wander()
            while(NpcActive)
                walk_rand(src,10)//walk randomly with 5 lag
            

                for(var/mob/M in hearers(6))//Check for players
                    if(M.client)
                        playercheck = 1
                    if(!playercheck)
                        NpcActive = 0
                sleep(1)
Oct 28 2013, 6:25 am
He's just going to copy and paste what ever you show him.

That's why he's having the instant crash cause he copy and pasted what Danny Roe showed him as if it was plug and play and probably smashed his keyboard until compile errors were no longer there.
Oct 28 2013, 7:44 am
And it's even worse when people post bad examples.

In reference to the latest code snippet given, var/playercheck has once again been left out of the ai_random_wander() proc.

You have also advised using walk_rand() instead of step_rand().

To the OP, I suggest you set your goals a little smaller until you understand the language better. Read through the Guide and check out some of the beginner tutorials.
Oct 28 2013, 11:29 am
That was copy and pasted from previous post. Was just giving an example as to how he should be using sleep in the while loop.
Oct 28 2013, 11:45 am
 
mob
    proc
        ai_random_wander()
            while(NpcActive)
                walk_rand(src,10)//walk randomly with 5 lag

                for(var/mob/M in hearers(6))//Check for players            var/playerehck=0 
                   if(M.client)
                        playercheck = 1
                    if(!playercheck)
                        src.NpcActive = 0
                        del(src)

Wouldn't this be better so when there is NO player the NPC just deletes...
Oct 28 2013, 12:05 pm
How would you make a new enemie?
Oct 28 2013, 12:07 pm
I have it so any npc that got killed/deleted gets restored back with World Restore proc so it would come back
Page: 1 2 3 4 5