Switch Input Problem

ID:139748
 
Sep 6 2010, 4:51 am
Code: Switch Input doesn't show up.
mob/Login()
    sleep(0)
    winset(src,"MainWindow.MainMap","icon-size=32")   //sets up the icon size
    src.loc=locate(181,165,10)
    Beginning
    switch(alert("Please login.","","New Character","Load Character","Delete Character"))
        if("New Character")
            switch(alert("Which Slot do you wish to Select?","","Slot 1","Slot 2","Slot 3"))
                if("Slot 1")
                    if(fexists("Slot1/[usr.key].sav"))
                        switch(alert("Warning a save file has been found would you like to overwrite this slot?","","Yes","No"))
                            if("Yes")
                                fdel("Slot1/[usr.key].sav")
                                usr.logged = 1
                                usr.cansave = 1
                                usr.usingslot = "1"
                                usr.client.eye=usr
                                usr.loc=locate(1,1,1)
                                usr.Name()
                                usr.LastName()
                        switch(input("Please select your gender.")in list("Male","Female"))
                            if("Male")
                                usr.icon= 'Base.dmi'
                                usr<<"Slot 2 Creation Complete"
                                usr.AddName()
                                return
                            if("Female")
                                usr.icon= 'FemaleBase.dmi'
                                usr<<"Slot 2 Creation Complete"
                                usr.AddName()
                                return
                            if("No")
                                goto Beginning
                    else
                        usr.logged = 1
                        usr.cansave = 1
                        usr.usingslot = "1"
                        usr.client.eye=usr
                        usr.loc=locate(1,1,1)
                        usr.Name()
                        usr.LastName()
                    if("Male")
                        usr.icon= 'Base.dmi'
                        usr<<"Slot 3 Creation Complete"
                        usr.AddName()
                        return
                    if("Female")
                        usr.icon= 'FemaleBase.dmi'
                        usr<<"Slot 3 Creation Complete"
                        usr.AddName()
                        return


Problem description: As the title states, the switch input, for people to choose between male/female, doesn't pop up.

Sep 6 2010, 5:43 am
Look at the arguments for the input() entry. Because of the empty "", you are telling alert() that the reference (who gets the message) is "Please login."
Sep 6 2010, 6:06 am
So, I when I remove the "" at the alert() proc, it won't show up New Character anymore.
Sep 6 2010, 6:16 am
In response to MitC
Did you even look up the arguments for alert() in order to see what I was talking about? There was a bit more than just the "" you had to remove...
Sep 6 2010, 8:55 am
In response to GhostAnime
That's not true since the Usr argument is optional and he passes "" as the Title argument.

Reference:
alert(Usr=usr,Message,Title,Button1="Ok",Button2,Button3)

OP's Code:
alert("Please login.","","New Character","Load Character","Delete Character")
Sep 6 2010, 2:05 pm
Your code is very inefficient and a jumbled mess to be honest, no surprise you cannot read it.

Most likely you do not have a save, so its never calling a switch for gender.

Please consider the following corrections:
Slots should be saved/loaded from a single save file using save file directories. You can follow the example left by Garthor at http://www.byond.com/developer/forum/?id=741034&single=1.

You should never use a goto/label. Instead you should use a loop and/or break each part up into separate protocols as it improves readability and efficiency.