attack code problems and exp problems

ID:138745
 
Dec 23 2011, 9:37 am
Code:
proc
        DeathCheck()
            if(src.HP<=0)
                world << "[src] died."
                usr.Exp+=src.Exp
                LevelCheck()
                if(src.client)
                    src.loc = locate(11,6,3)
                    src.HP = src.MaxHP
                else
                    del (src)
        
        LevelCheck()
            if (usr.Exp <= usr.Nexp)
                usr << "Level up"
                usr.Nexp += 100
                usr.Exp = 0

Attack(mob/M as mob in oview(1))
            var/damage = usr.Str - M.Def
            if(damage <= 0)
                usr << "[M] Is to strong!!!"
                M << "You are surperior to [usr]'s attack."
            else
                M.HP -= damage
                view() << "[usr] attacks [M] for [damage] HP!"
                M:DeathCheck()


Problem description:when i kill something i get my nexp added to my exp making me level up everytime it dies, how would i make the enemy exp be added to mine rather than what it is now,also my character attacks, but doesn't use the attacking animation, how would i change the attack verb to show that animation.

Dec 23 2011, 11:08 am (Edited on Dec 23 2011, 11:18 am)
Use 
flick("icon state here",src)
for your attacking animation.

So that would be:
Attack(mob/M as mob in oview(1))
            var/damage = usr.Str - M.Def
            if(damage <= 0)
                usr << "[M] Is to strong!!!"
                M << "You are surperior to [usr]'s attack."
            else
                flick("icon state here",src)
                M.HP -= damage
                view() << "[usr] attacks [M] for [damage] HP!"
                M:DeathCheck()


And why do you check if the mobs Nexp variable is higher than it's Exp variable? Shouldn't it be the other way around?
        LevelCheck()
            if (usr.Exp >= usr.Nexp)
                usr << "Level up"
                usr.Nexp += 100
                usr.Exp = 0


Dec 24 2011, 12:46 am
In response to MitC
Thanks fixed all of the problems, im new to this as you can notice
Dec 24 2011, 7:25 am
In response to PlucvbYoutube1
I thought so, hope you learned from my comments :).