Mouseclicks Freezing Movement

Page: 1 2
Jun 22 2013, 7:47 am
Also fixed, but to no avail. For the record, when I remove the .dmf from compilation and run it, everything works smoothly except of course the right-clicks, which do nothing.
Jun 22 2013, 7:50 am
Even your click procs and such?
Jun 22 2013, 8:31 am
Yes. I can click-to-target and then attack without it effecting my movement. Now, I haven't redefined Move() at all, so I'm convinced that it has something to do with either the interface file or the bit of code that checks for right-clicks.
Jun 22 2013, 8:45 am
Okay and then also I just reduced the code to the following:

//Attack and Defend Controls
client
    Click(object,location,control,params)

        if(..())        //If overriden by other procs(namely the targetting proc), return
            return
        else            //If not overriden, initiate an attack
            usr.attack()
            ..()

Compiled and ran it and it still gives the same issue. I can attack or target, but it'll freeze movement whether I left or right click.

Thing is, I have no sort of experience with .dmf so I'm quite clueless as to what I'm doing. I've been looking for a tutorial. Essentially, my interface file just has a map though.
Jun 22 2013, 9:00 am
Er. The ..() under the else clause is kind of pointless. ..() is called inside the if-statement.

Can you open up your DMF file in notepad, and paste the contents here in DM tags?
Jun 22 2013, 9:08 am
DMF Code:
macro "macro"
    elem 
        name = "North+REP"
        command = ".north"
        is-disabled = false
    elem 
        name = "South+REP"
        command = ".south"
        is-disabled = false
    elem 
        name = "East+REP"
        command = ".east"
        is-disabled = false
    elem 
        name = "West+REP"
        command = ".west"
        is-disabled = false
    elem 
        name = "Northeast+REP"
        command = ".northeast"
        is-disabled = false
    elem 
        name = "Northwest+REP"
        command = ".northwest"
        is-disabled = false
    elem 
        name = "Southeast+REP"
        command = ".southeast"
        is-disabled = false
    elem 
        name = "Southwest+REP"
        command = ".southwest"
        is-disabled = false
    elem 
        name = "Center+REP"
        command = ".center"
        is-disabled = false


menu "menu"
    elem 
        name = "&Quit"
        command = ".quit"
        category = "&File"
        is-checked = false
        can-check = false
        group = ""
        is-disabled = false
        saved-params = "is-checked"


window "default"
    elem "default"
        type = MAIN
        pos = 0,0
        size = 640x480
        anchor1 = none
        anchor2 = none
        font-family = ""
        font-size = 0
        font-style = ""
        text-color = #000000
        background-color = none
        is-visible = true
        is-disabled = false
        is-transparent = false
        is-default = true
        border = none
        drop-zone = false
        right-click = false
        saved-params = "pos;size;is-minimized;is-maximized"
        on-size = ""
        title = ""
        titlebar = true
        statusbar = true
        can-close = true
        can-minimize = true
        can-resize = true
        is-pane = false
        is-minimized = false
        is-maximized = false
        can-scroll = none
        icon = ""
        image = ""
        image-mode = stretch
        keep-aspect = false
        transparent-color = none
        alpha = 255
        macro = "macro"
        menu = "menu"
        on-close = ""

window "window1"
    elem "window1"
        type = MAIN
        pos = 281,0
        size = 2259x1343
        anchor1 = none
        anchor2 = none
        font-family = ""
        font-size = 0
        font-style = ""
        text-color = #000000
        background-color = none
        is-visible = true
        is-disabled = false
        is-transparent = false
        is-default = false
        border = none
        drop-zone = false
        right-click = false
        saved-params = "pos;size;is-minimized;is-maximized"
        on-size = ""
        title = ""
        titlebar = true
        statusbar = true
        can-close = true
        can-minimize = true
        can-resize = true
        is-pane = false
        is-minimized = false
        is-maximized = true
        can-scroll = none
        icon = ""
        image = ""
        image-mode = stretch
        keep-aspect = false
        transparent-color = none
        alpha = 255
        macro = ""
        menu = ""
        on-close = ""
    elem "info1"
        type = INFO
        pos = 1352,0
        size = 1184x432
        anchor1 = none
        anchor2 = none
        font-family = ""
        font-size = 0
        font-style = ""
        text-color = #000000
        background-color = #ffffff
        is-visible = true
        is-disabled = false
        is-transparent = false
        is-default = false
        border = none
        drop-zone = true
        right-click = false
        saved-params = ""
        on-size = ""
        highlight-color = #00ff00
        tab-text-color = #000000
        tab-background-color = none
        tab-font-family = ""
        tab-font-size = 0
        tab-font-style = ""
        allow-html = true
        multi-line = true
        on-show = ""
        on-hide = ""
        on-tab = ""
    elem "map1"
        type = MAP
        pos = 0,0
        size = 1352x1336
        anchor1 = none
        anchor2 = none
        font-family = ""
        font-size = 0
        font-style = ""
        text-color = none
        background-color = none
        is-visible = true
        is-disabled = false
        is-transparent = false
        is-default = false
        border = none
        drop-zone = true
        right-click = true
        saved-params = "icon-size"
        on-size = ""
        icon-size = 0
        text-mode = false
        on-show = ""
        on-hide = ""
        style = ""
Jun 22 2013, 9:12 am
Best response
Well, there's your issue. You created a second window, where the macro set for the window is not set. Meaning, whenever you set focus to that window, the macros for movement don't work, because the window doesn't have any set.

Go to the window the map, edit the actual window, Go into the Options tab. Type "macro" into the box labeled "Macro ID".


Do you really want two windows, though?
Jun 22 2013, 9:19 am
Awesome, thank you!

No, I didn't know what the hell I was doing lol. Is there a good guide for interfaces out there?

Jun 22 2013, 9:22 am
Lummox JR's skin tutorial does an okay job of introducing interfaces I guess.

For manipulation of interfaces during runtime, there's a few entries in the reference, they all begin with "win". (winget, winset, winclone, etc), and then there's the Skin Reference. The skin ref is also available in Dream Maker, in the Help menu.
Jun 22 2013, 9:25 am
Oh, and one last question. After redefining click-to-target from this...

mob
    Click()
        var/C = src
        if (usr == src)
            return 0
        if(src==usr.target)
            return 0
        else
            usr:Target(C)
            return ..()


...to this...

mob
    Click(mob/C)
        if(C == usr)
            return 0
        if(C == usr.target)
            return 0
        else
            usr:Target(C)
            return ..()


...it appears that everytime I click to target a mob, it places the reticle over it, but when the mob moves the reticle stays in place.

Now I'm pretty sure that, for whatever reason, it's treating mob/C as the location of the click as opposed to the object. Why would it do that?

Granted, I could fix this by reverting it back, but I just want to get a better understanding of what's going on.
Jun 22 2013, 9:29 am
Well, you're using mob/Click() wrong in that example.

If you look at the reference entry for atom/Click():

Click(location,control,params)

location: the turf, stat panel, grid cell, etc. in which the object was clicked


So, in that last snippet you posted, 'C' would be the turf the mob is standing on. You're better off keeping it as "src" there.

src is the being clicked. usr is the thing doing the clicking.

The first argument of Click() is the location of src, either a turf, cell, or interface element (depending on where it's clicked).
Jun 22 2013, 9:38 am
So essentially, atom/Click() doesn't have an argument for the object as opposed to the other click procs. That makes sense now.

And also using src, despite the nature of it, does the same thing. So I guess in this case it'd be best to just define the variable outside of the arguments as I had previously.
Jun 22 2013, 9:41 am
Well, there's only two click procs.

client/Click() and atom/Click(). mob/Click() etc is descended from atom/Click()

client/Click(atom/object) calls object.Click() by default.

The atom/Click() is called on the object from client/Click(), so "src" is the object that Click() is called on.
Jun 22 2013, 10:00 am
I've come to the realization that defining them all within client/Click() is much simpler.

client
    Click(object,location,control,params)
        var/list/p = params2list(params)
        
        if(p["right"])  //If it was a right-click, then defend
            usr.defend()
            ..()
        
        
        else                    //If not a right-click....

            if(ismob(object))   //If an object is clicked on and it's a mob, then target it.
                if (usr == src)
                    return 0
                if(src!=usr.target)
                    usr:Target(object)
                    return ..()
            else                //Otherwise, attack.
                usr.attack()
                ..()


Thanks for all your help, guys. :D
Jun 22 2013, 10:03 am
You should probably just call ..() once (ever) outside of everything. Returning ..() does nothing.
Jun 22 2013, 10:06 am
Yeah, sorry. That was originally in there because there was an if(..()) statement at one point to check if the mob/Click() would override it. If a player was targeting someone, I didn't want it also attacking in the same click.'

//Attack, Target, and Defend Controls
client
    Click(object,location,control,params)
        var/list/p = params2list(params)
        
        if(p["right"])  //If it was a right-click, then defend
            usr.defend()
            return
        
        
        else                    //If not a right-click....

            if(ismob(object))   //If an object is clicked on and it's a mob, then target it.
                if (usr == src)
                    return
                if(src!=usr.target)
                    usr:Target(object)
                    return
            else                //Otherwise, attack.
                usr.attack()
        ..()

Better?
Jun 22 2013, 10:16 am
You should probably combine the ismob check with the usr==object check. Also - you're still using src in your if-statements, you probably want that that to be object. Src is the client itself, in this proc.
            if(ismob(object) && usr != object)
                if(object != usr.target) 
                    usr.Target(object)
            else usr.attack()


probably.
Page: 1 2