Help with FFA Code

ID:1091233
 
Dec 20 2012, 4:56 pm
(See the best response by NNAAAAHH.)
Code:
    FFA_Check(var/mob/M in Entries)
        fight
            if(M.z==3)
                world<<"<font color=red><b>[M] has been eliminated!"
                M.tourny = 0
                Entries.Remove(M)
                Winners.Remove(M)
                M.AllorNone = 0
                goto fight
        if(Entries.len>1)
            sleep(5)
            FFA_Check()
        if(Entries.len==1)
            tournament=0
            world<<"Tournament over, winner is:"
            for(var/mob/N in Entries)
                world<<N
                Winners.Add(N)
                Entries.Remove(N)


Problem description: Im trying to come up with a code that checks for players who have died in free for all. When I do it though, nothing happens, and its been pissing me off. Any help would be appreciated.

Dec 21 2012, 5:32 am
Best response
I know your heart is in the right place with this and you want to complete it, but you need to take a few steps back and read through the DM Guide.

http://www.byond.com/docs/guide/
http://www.byond.com/docs/ref/index.html
http://www.byond.com/forum/?forum=22

As for your issue- You don't want to use goto loops, that's for-sure. Then you don't want to base your work off someone else's- especially when it's making a new system.

*Use while() loops, don't call the same proc over and over by sleep() procName(), FFA_Check(var/mob/M in Entries does nothing here.

proc/FFA_Check()//remove the check for a mob here.
    while(container.len>1)//don't use a label and goto for a loop
        for(var/mob/m in container)//check each mob in the container
            if(m.varName)//check each mob's varName variable.
                container.Remove(m)//remove that specific mob from the container.
         sleep(delay)//ensure your loop doesn't crash the project.
    SecondaryProc()//call the next proc to do whatever else you need. This will ONLY run AFTER the len of the container reaches below 2.(1 or below) This SecondaryProc() can simply be a proc to check the winner, if any. OR, you could use it to reset the tournament at a later time.

[EDIT] I saw this yesterday and didn't want to touch it, since it seems you're working on a dbz rip with a tournament code in it. In which case, I don't know why you check the z and not the dead variable. [END EDIT]
Dec 21 2012, 10:21 am
Already read the DM guide, and a lot of references. I coded for a few months, stopped from August-December cause of college, and now am back obviously forgetting some concepts. Thank you very much.