Just posted my first library:
http://www.byond.com/developer/Hi1/RadioChat
Check it out! :)
Aug 16 2010, 5:16 pm
|
|
Haha, beat you to it. Sorry man. You made the second Radio demo...this is the first.
|
Albro1 wrote:
Haha, beat you to it. Sorry man. You made the second Radio demo...this is the first. Ahh! Well, alright. I'll think of something else. :P |
There's several things wrong in just this little bit of code. I'm not going to bother explaining what they are, I just suggest that you go back and learn a little of DM before you insist on helping others.
|
Andrew sertsis wrote:
There's several things wrong in just this little bit of code. I'm not going to bother explaining what they are, I just suggest that you go back and learn a little of DM before you insist on helping others. An excellent way to learn is to create a library or demo and get feedback about it. Explaining the problems you found would be very helpful, provided that you actually found problems and aren't just claiming to have found some to look smart. I would suggest putting setting the focus back to the input field when you switch chat types (add "focus=true" to the winset parameters). People will usually switch chat types when they're about to type a message so you can save them the extra click. |
Well, to give an argument against: while it is an excellent way to get feedback, I'd say publishing unpolished code and tagging it as a demo or library is misleading. Therefore, in my opinion, such code should be submitted for peer review before being published. People here already learn a lot of bad practices from the large amount of bad code available (rips are a case in point).
(This comment is not related to the library here, I haven't downloaded it.) |