expected expression error

ID:149118
 
Jul 2 2002, 6:59 am
mob
proc
line=14 Attack{mob/M in oview{1,}
var/damage = rand{,1 usr.strength}
damage -= defence
M.health -= damage
M.DeathCheck()

i lables line 14 and the error is expected expression can anyone help me out please.
Jul 2 2002, 7:42 am
Ss5trunks99 wrote:
mob
proc
line=14 Attack{mob/M in oview{1,}
var/damage = rand{,1 usr.strength}
damage -= defence
M.health -= damage
M.DeathCheck()

i lables line 14 and the error is expected expression can anyone help me out please.

Those should be (parens), not {braces}
Jul 2 2002, 8:58 am
In response to Skysaw
i changed it now i get this error

mob
proc
Attack(mob/M in oview(1)
var/damage = rand(1, usr.strength)
damage -= defence
M.health -= damage
M.DeathCheck()

monsters.dm:15:error: var: missing comma ',' or right-paren ')'
Jul 2 2002, 9:03 am
In response to Ss5trunks99
Ss5trunks99 wrote:
i changed it now i get this error

mob
proc
Attack(mob/M in oview(1)<font color=yellow>) <-- right there</font>
var/damage = rand(1, usr.strength)
damage -= defence
M.health -= damage
M.DeathCheck()

monsters.dm:15:error: var: missing comma ',' or right-paren ')'
Jul 2 2002, 9:31 am
In response to Skysaw
thanks

now i have errors all over this code

mob
monsters
var
think_dalay = 10
New()
..()
spawn(rand(1,think_delay))AILoop()
proc/AILoop()
var/action_taken
for(mob/M in oview(src))
if(istype(M,/mob/monsters))
continue //it doesn't attack monsters
step_toward(src,M)
action_taken = 1
for(mob/monsters/M in oview(1,src))
if(istype(M,/mob/monsters))
continue
Attack(M)
action_taken = 1
if(action_taken)
spawn(think_delay)
AILoop()
return
..()

monsters.dm:16:error:defence:undefined var
monsters.dm:31:error:mob:undefined var
monsters.dm:31:error:M:undefined var
monsters.dm:32:error:M:undefined var
monsters.dm:34:error:M:undefined var
monsters.dm:34:error:step_toward:undefined proc
monsters.dm:36:error:mob:undefined var
monsters.dm:36:error:monsters:undefined var
monsters.dm:36:error:M:undefined var
monsters.dm:37:error:M:undefined var
monsters.dm:39:error:M:undefined var
monsters.dm:28:error:think_delay:undefined var
monsters.dm:41:error:action_taken:value not allowed here
monsters.dm:42:error:think_delay:value not allowed here
monsters.dm:43:error::empty type name (indentation error?)
monsters.dm:44:error:return :instruction not allowed here
monsters.dm:42:error::empty type name (indentation error?)
monsters.dm:17:error:M.health:undefined var
monsters.dm:14:error:Attack :duplicate definition
stats.dm:16:error:Attack :previous definition
monsters.dm:31:/ :warning: statement has no effect
monsters.dm:31:error::bad assignment
monsters.dm:32:if :warning: if statement has no effect
monsters.dm:36:/ :warning: statement has no effect
monsters.dm:36:error::bad assignment
monsters.dm:30:action_taken :warning: variable defined but not used

Jul 2 2002, 10:03 am
In response to Ss5trunks99
Ss5trunks99 wrote:
thanks

now i have errors all over this code

mob
monsters
var
think_dalay = 10
New()
..()
spawn(rand(1,think_delay))AILoop()
proc/AILoop()
var/action_taken
for(mob/M in oview(src))
if(istype(M,/mob/monsters))
continue //it doesn't attack monsters
step_toward(src,M)
action_taken = 1
for(mob/monsters/M in oview(1,src))
if(istype(M,/mob/monsters))
continue
Attack(M)
action_taken = 1
if(action_taken)
spawn(think_delay)
AILoop()
return
..()

monsters.dm:16:error:defence:undefined var
monsters.dm:31:error:mob:undefined var
monsters.dm:31:error:M:undefined var
monsters.dm:32:error:M:undefined var
monsters.dm:34:error:M:undefined var
monsters.dm:34:error:step_toward:undefined proc
monsters.dm:36:error:mob:undefined var
monsters.dm:36:error:monsters:undefined var
monsters.dm:36:error:M:undefined var
monsters.dm:37:error:M:undefined var
monsters.dm:39:error:M:undefined var
monsters.dm:28:error:think_delay:undefined var
monsters.dm:41:error:action_taken:value not allowed here
monsters.dm:42:error:think_delay:value not allowed here
monsters.dm:43:error::empty type name (indentation error?)
monsters.dm:44:error:return :instruction not allowed here
monsters.dm:42:error::empty type name (indentation error?)
monsters.dm:17:error:M.health:undefined var
monsters.dm:14:error:Attack :duplicate definition
stats.dm:16:error:Attack :previous definition
monsters.dm:31:/ :warning: statement has no effect
monsters.dm:31:error::bad assignment
monsters.dm:32:if :warning: if statement has no effect
monsters.dm:36:/ :warning: statement has no effect
monsters.dm:36:error::bad assignment
monsters.dm:30:action_taken :warning: variable defined but not used


Seems like you haven't been defining many of your variables, and you seem to have a weak grasp on how BYOND even works.

I would recommend reading some of the tutorials that are provided in the Tutorial section of the website before you attempt writing a game on your own. :)

- Malver
Jul 2 2002, 10:12 am
In response to Ss5trunks99
There is a lot wrong here. Try adding just a little bit of code at a time, and see what works. Here's what I noticed off the bat. There's probably more, but it's a tangle.

mob
monsters <font color=yellow>- unindent one space</font>
var
think_dalay = 10 <font color=yellow>- spelled "delay," while I'm here...</font>
New()
..() <font color=yellow>- unindent one space</font>
spawn(rand(1,think_delay))AILoop()
proc/AILoop()
var/action_taken
for(mob/M in oview(src)) <font color=yellow>should be for(var/mob/M in oview(src))</font>
if(istype(M,/mob/monsters))
continue //it doesn't attack monsters
step_toward(src,M) <font color=yellow>Not sure if this will execute. Why is it indented? Also, it's "step_towards"</font>
action_taken = 1 <font color=yellow>unindent several spaces</font>
for(mob/monsters/M in oview(1,src)) <font color=yellow>unindent one space</font>
if(istype(M,/mob/monsters))
continue
Attack(M) <font color=yellow>unindent</font>
action_taken = 1 <font color=yellow>unindent</font>
if(action_taken)
spawn(think_delay)
AILoop() <font color=yellow>indent one space</font>
return
..()

You may need to work on something a little simpler, until you get a better grasp of the language.
Jul 2 2002, 10:29 am
In response to Skysaw
Skysaw wrote:
There is a lot wrong here. Try adding just a little bit of code at a time, and see what works. Here's what I noticed off the bat. There's probably more, but it's a tangle.

mob
monsters
var
think_dalay = 10
New()
..() > > spawn(rand(1,think_delay))AILoop()<font color=red> final error </font>
proc/AILoop()
var/action_taken
for(mob/M in oview(src))
if(istype(M,/mob/monsters))
continue //it doesn't attack monsters
step_toward(src,M)
action_taken = 1
for(mob/monsters/M in oview(1,src)) > > if(istype(M,/mob/monsters))
continue
Attack(M) > > action_taken = 1 > > if(action_taken)
spawn(think_delay)
AILoop() > > return
..()

You may need to work on something a little simpler, until you get a better grasp of the language.

thats the last one
monsters.dm:28:error: proc definition not allowed inside another proc
Jul 2 2002, 10:31 am
In response to Malver
Malver wrote:
Ss5trunks99 wrote:
thanks

now i have errors all over this code

mob
monsters
var
think_dalay = 10
New()
..()
spawn(rand(1,think_delay))AILoop()
proc/AILoop()
var/action_taken
for(mob/M in oview(src))
if(istype(M,/mob/monsters))
continue //it doesn't attack monsters
step_toward(src,M)
action_taken = 1
for(mob/monsters/M in oview(1,src))
if(istype(M,/mob/monsters))
continue
Attack(M)
action_taken = 1
if(action_taken)
spawn(think_delay)
AILoop()
return
..()

monsters.dm:16:error:defence:undefined var
monsters.dm:31:error:mob:undefined var
monsters.dm:31:error:M:undefined var
monsters.dm:32:error:M:undefined var
monsters.dm:34:error:M:undefined var
monsters.dm:34:error:step_toward:undefined proc
monsters.dm:36:error:mob:undefined var
monsters.dm:36:error:monsters:undefined var
monsters.dm:36:error:M:undefined var
monsters.dm:37:error:M:undefined var
monsters.dm:39:error:M:undefined var
monsters.dm:28:error:think_delay:undefined var
monsters.dm:41:error:action_taken:value not allowed here
monsters.dm:42:error:think_delay:value not allowed here
monsters.dm:43:error::empty type name (indentation error?)
monsters.dm:44:error:return :instruction not allowed here
monsters.dm:42:error::empty type name (indentation error?)
monsters.dm:17:error:M.health:undefined var
monsters.dm:14:error:Attack :duplicate definition
stats.dm:16:error:Attack :previous definition
monsters.dm:31:/ :warning: statement has no effect
monsters.dm:31:error::bad assignment
monsters.dm:32:if :warning: if statement has no effect
monsters.dm:36:/ :warning: statement has no effect
monsters.dm:36:error::bad assignment
monsters.dm:30:action_taken :warning: variable defined but not used


Seems like you haven't been defining many of your variables, and you seem to have a weak grasp on how BYOND even works.

I would recommend reading some of the tutorials that are provided in the Tutorial section of the website before you attempt writing a game on your own. :)

- Malver

thanks for the tip mal but i have gone through the codes it isnt that i didnt name vars it was indents and one mispell
Jul 2 2002, 10:38 am
In response to Ss5trunks99
what's with all the "> >"s?? It looks like you are cramming several lines together in a couple of places. What are you trying to do?
Jul 2 2002, 10:42 am
In response to Skysaw
thats how it pasted onto the forum it really isnt like that in my code
Jul 2 2002, 10:49 am
In response to Ss5trunks99
Ss5trunks99 wrote:
thats how it pasted onto the forum it really isnt like that in my code

Paste it in a way that it looks like your code.
Jul 2 2002, 10:51 am
In response to Skysaw
mob
monsters
var
think_delay = 10
New()
..()
spawn(rand(1,think_delay))AILoop()
proc/AILoop()
var/action_taken
for(var/mob/M in oview(src))
if(istype(M,/mob/monsters))
continue //it doesn't attack monsters
step_towards(src,M)
action_taken = 1
for(mob/monsters/M in oview(1,src))
if(istype(M,/mob/monsters))
continue
Attack(M)
action_taken = 1
if(action_taken)
spawn(think_delay)
AILoop()
return
..()
Jul 3 2002, 5:23 am
can anyone find the last error solution?
Jul 3 2002, 5:29 am
In response to Ss5trunks99
Ss5trunks99 wrote:
mob
monsters
var
think_delay = 10 <font color=yellow>bad indent</font>
New()
..()
spawn(rand(1,think_delay))AILoop()
proc/AILoop()
var/action_taken
for(var/mob/M in oview(src))
if(istype(M,/mob/monsters))
continue //it doesn't attack monsters <font color=yellow>bad indent</font>
step_towards(src,M)
action_taken = 1
for(mob/monsters/M in oview(1,src))
if(istype(M,/mob/monsters))
continue <font color=yellow>bad indent</font>
Attack(M) <font color=yellow>bad indent</font>
action_taken = 1 <font color=yellow>bad indent</font>
if(action_taken)
spawn(think_delay)
AILoop()
return
..() <font color=yellow>bad indent</font>
Jul 3 2002, 5:35 am
In response to Skysaw
do you have aim or msn so i can sow you how the code really works