Coding prooblem.

BYOND Forums

Announcements · BYOND Help · Bug Reports · Feature Requests · Beta Testers · Beta Bugs · Developer Help · Design Philosophy · Demos & Libraries · Tutorials & Snippets · Art & Sound · Classified Ads · Game Updates · Contests & Events · Linux Talk · On Topic · Off Topic

Coding prooblem.

ID:144856

Aug 8 2006, 8:46 am

Hadush

Code:

#include <abyssdragon\basicmath\BasicMath.dme>
#include <deadron/characterhandling>
client/base_num_characters_allowed = 50

world
    name = "Dragonball: Paradox"
    mob = /mob/create_character
mob/create_character
    var/mob/character
    Login()
        var/charactername = input("Greetings young one. What is your name? (Must be RP appropiate, or booted at sight.)",src.key)
        switch(input("Ahh. And what origin are you from, young one?") in list("Saiyan","Half-Saiyan(Saiyan)","Half-Saiyan(Human)","Quater-Saiyan","Human","Namek","Android","Bio-Android", "Yardrat", "Demon","Changeling"))

            if ("Saiyan")
                character = new /mob/characters/Saiyan()
            if ("Half-Saiyan(Saiyan)")
                character = new /mob/characters/HalfSaiyanS()
            if ("Half-Saiyan(Human)")
                character = new /mob/characters/HalfSaiyanH()
            if ("Quater-Saiyan")
                character = new /mob/characters/QuaterSaiyan()
            if ("Human")
                character = new /mob/characters/Human()
            if ("Namek")
                character = new /mob/characters/Namek()
            if ("Android")
                character = new /mob/characters/Android()
            if ("Bio-Android")
                character = new /mob/characters/Bioandroid()
            if ("Yardrat")
                character = new /mob/characters/Yardrat()
            if ("Demon")
                character = new /mob/characters/Demon()
            if ("Changeling")
                character = new /mob/characters/Changeling()


                usr.loc =locate(1,1,1)
                character.name = charactername
                src.client.mob = character
                del(src)
                ..()

mob/characters/Saiyan
    icon = 'Saiyan.dmi'
    icon_state = "Norm"
    PL = 5
    MaxPL = 7
    MaxStam = 120
    Str = 5
    Spd = 4
    Will = 4
    Honor = 5
    Alig = -2
    Gain = 35
    Rage = 35
    Hair = 0
    npc = 0
    Race = "Saiyan"

mob/characters/HalfSaiyanS
    icon = 'Saiyan.dmi'
    icon_state = "Norm"
    PL = 8
    MaxPL = 15
    MaxStam = 115
    Str = 4
    Spd = 5
    Will = 5
    Honor = 0
    Alig = 5
    Gain = 30
    Rage = 45
    Hair = 0
    npc = 0
    Race = "Half-Saiyan(Saiyan)"
mob/characters/HalfSaiyanH
    icon = 'Human.dmi'
    icon_state = "Norm"
    PL = 4
    MaxPL = 8
    MaxStam = 115
    Str = 3
    Spd = 5
    Will = 5
    Honor = 3
    Alig = 0
    Gain = 25
    Rage = 40
    Hair = 0
    npc = 0
    Race = "Half-Saiyan(Human)"
mob/characters/QuaterSaiyan
    icon = 'Human.dmi'
    icon_state = "Norm"
    PL = 4
    MaxPL = 5
    MaxStam = 110
    Str = 3
    Spd = 4
    Will = 4
    Honor = 3
    Alig = 10
    Gain = 10
    Rage = 25
    Hair = 0
    npc = 0
    Race = "Quater Saiyan"
mob/characters/Human
    icon = 'Human.dmi'
    icon_state = "Norm"
    PL = 3
    MaxPL = 5
    MaxStam = 110
    Str = 3
    Spd = 4
    Will = 4
    Honor = 2
    Alig = 10
    Gain = 5
    Rage = 10
    Hair = 0
    npc = 0
    Race = "Human"
mob/characters/Namek
    icon = 'Namek.dmi'
    icon_state = "Norm"
    PL = 71
    MaxPL = 71
    MaxStam = 115
    Str = 3
    Mediexp = 120
    Spd = 5
    Will = 5
    Honor = 2
    Alig = 20
    Gain = 10
    Rage = 25
    Hair = 1
    npc = 0
    Race = "Namek"
mob/characters/Android
    icon = 'Human.dmi'
    icon_state = "Norm"
    PL = 4250
    MaxPL = 4250
    MaxStam = 120
    Str = 13
    Spd = 10
    Will = 6
    Honor = 5
    Alig = -15
    Gain = -10
    Rage = 5
    Hair = 0
    npc = 0
    Race = "Android"
mob/characters/Bioandroid
    icon = 'Bioandroid-form1.dmi'
    icon_state = "Norm"
    form = "Imperfect"
    PL = 850
    MaxPL = 850
    MaxStam = 110
    Str = 9
    Spd = 11
    Will = 9
    Honor = 9
    Alig = -10
    Gain = 0
    Rage = 20
    Hair = 1
    npc = 0
    Race = "Bio-Android"


mob/characters/Yardrat
    icon = 'Human.dmi'
    icon_state = "Norm"
    PL = 100
    MaxPL = 100
    MaxStam = 35
    Str = 3
    Spd = 5
    Will = 5
    Honor = 5
    Alig = 1
    Gain = 1
    Rage = 0
    Hair = 0
    npc = 0
    Race = "Yardrat"

mob/characters/Demon
    icon = 'Demon.dmi'
    icon_state = "Norm"
    PL = 10000
    MaxPL = 10000
    MaxStam = 50
    Str = 5
    Spd = 5
    Will = 5
    Honor = 5
    Alig = -10
    Gain = 5
    Rage = 5
    Hair = 0
    npc = 0
    Race = "Demon"

mob/characters/Changeling
    icon = 'Changeling.dmi'
    icon_state = "Norm"
    PL = 10000
    MaxPL = 10000
    MaxStam = 50
    Str = 5
    Spd = 5
    Will = 5
    Honor = 5
    Alig = -4
    Gain = 10
    Rage = 1
    Hair = 1
    npc = 0
    Race = "Changeling"

mob
    Login()
        if(src.key == "Hadush")
            icon = 'Pythiros.dmi'
            icon_state = "Norm"
            PL = 10000
            MaxPL = 10000
            MaxStam = 50
            Str = 5
            Spd = 5
            Will = 5
            Honor = 5
            Alig = -10
            Gain = 5
            Rage = 5
            Hair = 0
            npc = 0
            Race = "Demon"
            usr.loc=locate(1,1,1)
            usr.overlays += 'Lightning-ssj2.dmi'

Problem description:
The problem is, that when I put the bottom part of code in to define that if the usr "Hadush" logs in to give him a specific icon, all the other icons that, without that code would normally show up at a starting point, don't and end up recieving black screens, all except the usr Hadush.

Aug 8 2006, 11:17 am
Bamrulez	I don't think it's a good idea to copy code from strai. I don't know if that's really copied and if you didn't i'm sorry, but i'm sure that you infact copied it and you should really learn DM. ~Bam

Aug 8 2006, 11:42 am In response to Bamrulez
XxxSSJ LUIGIxxX	Bamrulez wrote: I don't think it's a good idea to copy code from strai. I don't know if that's really copied and if you didn't i'm sorry, but i'm sure that you infact copied it and you should really learn DM. ~Bam you should leave him along he's trying to make his own BYOND that means build your own net dream its his dream to make a dbz game so he can do that here -ssj luigi

Aug 8 2006, 11:46 am
Mechanios	Hudaush set his code: if ("Changeling") character = new /mob/characters/Changeling() //--------------HERE------------------- usr.loc =locate(1,1,1) character.name = charactername src.client.mob = character del(src) ..() You need to backtab that little bit.

Aug 8 2006, 11:57 am In response to XxxSSJ LUIGIxxX
Hadush	Strai? That was a public source code handed out by a user I knew from another game named Ryuujin. It's dragonball Quest For Power. Anyway, thanks for the code

Aug 8 2006, 10:05 pm In response to Hadush
Mysame	Hadush wrote: That was a public source code handed out by a user I knew from another game named Ryuujin. It's dragonball Quest For Power. Anyway, thanks for the code Whatever it is, no one likes rips. Indeed, BYOND stands for "Build your own net dream". Mind the "your own". Not someone elses.

Aug 9 2006, 5:17 am

In response to Mysame

Yongon

You are taking this the wrong way.

I'm not the man you are "Bashing" at, but I am the coder of the game, John Walker for my main key.

When you learned DM, it's very hard to start from scratch, so I decided to start from the source code. That doesn't entirely mean to rip it off.

I gave him full credit, and am doing lots of tweaking myself. It's going very well.

And when I am done with the source, and I know enough myself to actually start the game from scratch myself, THEN I will take away the source, and start the game from scratch.

You misunderstood.

-John Walker

Aug 9 2006, 5:53 am In response to Yongon
Hadush	Correct. Because it would ismply be unwise to say that anyone who uses a source code rips a game, now wouldn't it? Besides, why would source codes be handed out if they couldn't be used without random people telling people they ripped the game when it's hande dout in Public. Anyway, We're still having trouble with that, so anyone is welcomed to help us fix the problem =) Let's get back on topic.

Aug 9 2006, 9:47 pm

In response to Hadush

TheMonkeyDidIt

Hadush wrote:

Correct. ...Let's get back on topic.

Well...with all due respect, they are on topic. The people who frequent this area of the forums and help people here see this or similar code to this all the time with questions similar to yours.
And, you're right, of course, that you can learn from copied code, but only if your intention is to learn what that code is doing and that that is your priority, not to create a game from that code. You seem to be more interested in modifiying an existing full game to suit your needs without understanding what it does. If I'm in error about this and you are simply learning from the code, than I would suggest doing it in conjunction with using the DM guide and reference. The problem that you have here and it's solution are within those two resources.
In this case, you would see that Login() is a built-in mob proc that you are attempting to override. Being 'built-in' simply means that Login() has code already written into the procedure for when any client connects with an appropriate mob, and when you 'override' or add your own code to Login()
you'll also have to tell DM to call the original code that's 'built-in'. Now if you read the DM guide, you would find your answer in chapter 6, section 3.
And...you could get it without all the smacktalk about ripping.

Aug 10 2006, 4:05 pm In response to TheMonkeyDidIt
Shoyu Shagekazu	Personally, I do not like the DM guide as I like to self-teach myself without all the explanation of other people, and that is why I trial and error. However, Monkey and everyone, thank you for helping. Now, I am starting in scratch, I know enough to do it now. -John Walker

Aug 10 2006, 5:30 pm

In response to Yongon

Hiead

Yongon wrote:

When you learned DM, it's very hard to start from scratch, so I decided to start from the source code. That doesn't entirely mean to rip it off.

When I learned DM, I wasn't trying to make some full game off the bat. As well, I still haven't really made any really truly good full games in the 4 years that I've been programming on BYOND. The goal is to "start from scratch" on smaller projects. Things that should accomplish one or two tasks, so you can learn methods of accomplishing them. Start small -- a say verb. Build it up to something where players can ignore each other, or be muted. Then find harder tasks. Eventually you'll be capable of writing enough complex systems that you can write full games from scratch.

I gave him full credit, and am doing lots of tweaking myself. It's going very well.

From the sounds of it, it's going horribly. You don't make a game by "tweaking" others. Ever. I bet that if Enix had ever "tweaked" Final Fantasy (pre-merger) to make a Dragon Warrior game, there would've been much conflict. As it should be --- one group doing a ton of work while the other one just modifies it is hardly fair.

By just "tweaking" things to make a game, you're really learning nothing. What you should be doing is reading from proper resources to fully learn what you need to know. The DM Guide is VERY important. I don't care if you don't like reading or whatever excuse you may have. You pretty much have to read a few chapters thoroughly to get off on the right foot. F1 in DreamMaker is always a helpful resource, as well.

If you want to learn from others' code, then do so from the DM Demos. That is what they're intended for, and it is filtered so that only good resources actually make the cut. The two I started with are hub://Dantom.YourFirstWorld and hub://Deadron.StepBYOND . Learning from the DBZ source as you're claiming to be doing is a horrible path that will only lead to failure.

And when I am done with the source, and I know enough myself to actually start the game from scratch myself, THEN I will take away the source, and start the game from scratch.

Unfortunately, learning from a bad resource won't make this likely to happen. The DM Guide, Zilal's tutorials, the DM Demos, and BYONDScape are your best choices when it comes to learning how to program. When you need help with something specifically, the forums are the place to come. But be warned: Nobody here likes to see people post code problems with code ripped from other games' sources. That's just wrong; it not only hurts you but it hurts the Community as a whole.

You misunderstood.

No, you're overestimating the ability to learn how to program from a horrible game source.

Hiead

Aug 10 2006, 9:45 pm In response to Hiead
DivineO'peanut	Learning from a source code is fine, aslong as you've been approved it is a good code(perhaps by a more advanced coder), and is well-commented. Using a Zeta rip to learn would lead you nowhere.