Tournament problem

ID:144232
 
Feb 15 2007, 2:04 am
Code:
turf/tournament
    Grass
        icon = 'Tounament.dmi'
        icon_state = "b"
        density = 0
        Bump
            usr.loc = locate(2,2,1)


Problem description:
Tournament.dm:16:error:usr.loc:undefined var

Feb 15 2007, 2:05 am
And yes i did read the DM guide but i don't get it
Feb 15 2007, 2:37 am
In response to Shomone
Bump()
Feb 15 2007, 3:34 am
In response to A.T.H.K
 
turf/tournament
    Grass
        icon = 'Tounament.dmi'
        icon_state = "b"
        density = 0
        Bump()
            usr.loc = locate(2,2,1)

Tournament.dm:15:error:Bump :undefined proc
Feb 15 2007, 4:38 am
In response to Shomone
 
turf/tournament
    Grass
        icon = 'Tounament.dmi'
        icon_state = "b"
        density = 0
        Enter(O)
            var/mob/M = O
            M.loc = locate(2,2,1)


This may work I suggest using Enter() rather than Bump()
with turfs.

- Miran94
Feb 16 2007, 4:55 am
In response to Shomone
Whoa! You REALLY need to read it again. And not skim it, mind you. Also read threw the DM Reference.
Feb 16 2007, 5:13 am
Shomone wrote:
Code:
> turf/tournament
>   Grass
>       icon = 'Tounament.dmi'
>       icon_state = "b"
>       density = 0
>       Bump
>           usr.loc = locate(2,2,1)
>

Problem description:
Tournament.dm:16:error:usr.loc:undefined var

Ok, there are quite a few things wrong with that. First off, you can't bump an object that is not dense (density=0). Secondly, processes have () following there name. In this case, those parenthesis would contain the object that was bumped into. Which brings us to the third item: Bump() is called by the object doing the bumping, not the object that was bumped into. This is the cause of your later "undefined proc" error, as, since turfs cannot move, they do not have a Bump() process to begin with.


Miran94 wrote:
> turf/tournament
>     Grass
>         icon = 'Tounament.dmi'
>         icon_state = "b"
>         density = 0
>         Enter(O)
>             var/mob/M = O
>             M.loc = locate(2,2,1)
>

This may work I suggest using Enter() rather than Bump()
with turfs.

- Miran94

This was much closer, but there is still one major flaw in it: any type of moving object can call Enter(), which could result in a bunch of monsters running around the arena. Also, to save time, you could switch "O" with "atom/movable/O", allowing you to change their location without defining another variable. Here's an example:

turf/tournament
    Grass
        icon = 'Tounament.dmi'
        icon_state = "b"
        density = 0
        Enter(atom/movable/O)
            if(istype(O,/mob/player)) //Check that they are of the type "/mob/player" before...
                O.loc = locate(2,2,1) //...Sending them to the new location
            return 0 //Don't allow anything else to enter, and stop the player from being moved onto this turf (don't want him moved back after just sending him away!)


Also, to the original poster, make sure you switch "/mob/player" with whatever type you want to allow in.
Feb 16 2007, 5:25 am
In response to DarkCampainger
And, such things absolutely belong in Entered(), not Enter(), which needs to just deteremine whether movements are allowed or not, and so may also be manually called for such checking.
Feb 16 2007, 5:32 am
In response to Kaioken
Yea, I though about that, but then changed my mind. If you use Entered(), then the best way to stop things from blocking the entrance would be to set their location to the old location. Otherwise someone could push a barrel into it or a monster might stand there and block it (You know how step_rand() tends to make AI's do evil things...) Enter() takes care of it more easily. Although I'm almost tempted to just set Enter() to allow players in, and then move the actual changing location part under Entered().

I guess it all depends on how the rest of his game works. If there's only one of these at the end of a narrow corridor, then he's going to want to prevent blocking. But if he lines a bunch of them up to make a huge door, then he could do whatever he wanted.
Feb 16 2007, 5:41 am (Edited on Feb 16 2007, 5:47 am)
In response to DarkCampainger
Correct; however you're possibly missing a bit. Thats why you use both: for instance, Enter() to only allow /mob/player's, and Entered() to re-locate them, which IS the safest and most correct and you've err, weirdly enough, already stated it in you post.
Again, it's simple:

Enter(),Exit() -- only calculate whether entrance/exitrance (:D) should be allowed and correspondingly return either 0,1 or the parent/default action (return ..())

Entered(),Exited() -- HERE do actions that should be triggered when entering/exiting the location.