Getting errors on making this AoE

ID:142144
 
Aug 12 2008, 12:03 pm
Code:
    PK_Rockin for(var/mob/M in oview(1))
            set category = "PSI"
            if(usr.psidelay == 1)
                usr << "\red Please wait before using PSI again."
                return
            if(M.pvp == "No")
                usr << "\red That player has Pvp turned off!"
                return

            if(usr.PP >= 15)//PP Cost
                usr.PP -= 15//PP Cost
                M.overlays+=image(icon='icon/pkflash.dmi',icon_state="explosion")//Overlay
                ////EFFECT//////////////////////////////////////////////////////////////
                var/damage = src.PSI + 25 - M.defense
                if(M.defense >= damage)
                    damage = 0
                M.hp -= damage
                M.updateHealth()
                src.exp += M.giveexp
                src.level_up()
                view(M) << sound("sound/flash.wav",,,3,100)
                //////////////////////////////////////////////////$2F/////////////////////
                view() << "\red[usr] used PK Rockin' on [M]! It quakes them for [damage] hp!"//Tells the target
                usr.PSI_Use += 1
                checkpsi()
                usr.psidelay()
                M.overlays-=image(icon='icon/pkflash.dmi',icon_state="explosion")
                M.death_check(src)

            else
                src << "\red Not enough PP!"
                return


Problem description:PSI.dm:139:error:PK_Rockin :invalid proc definition
PSI.dm:140:error::invalid proc definition
inventory\healthbartest.dm:7:error:updateHealth :previous definition
Combat.dm:110:error:death_check :previous definition
Combat.dm:173:error:level_up :previous definition
PSI.dm:13:error:checkpsi :previous definition
PSI.dm:29:error:psidelay :previous definition
PSI.dm:12:error:/mob/psi/verb/PK_Rockin:not a prototype
PSI.dm:28:error:/mob/psi/verb/PK_Rockin:not a prototype
PKFire_project.dm:17:error:checkpsi:undefined type: checkpsi
PSI.dm:56:error:checkpsi:undefined type: checkpsi
PSI.dm:84:error:src.level_up:undefined type: src.level_up
PSI.dm:89:error:checkpsi:undefined type: checkpsi
PSI.dm:126:error:src.level_up:undefined type: src.level_up
PSI.dm:131:error:checkpsi:undefined type: checkpsi


Aug 12 2008, 12:13 pm
First, why would you make a new thread, I mean, seriously.
Next, you defined the proc wrong. Bakasensei explained well enough that anyone who read the guides would understand what he meant, so I suggest you read the DM and ZBT guides. It should all make sense after that.
Aug 12 2008, 12:20 pm
In response to Giantpandaman
I made a new topic because it no longer fit in the other seciton it is now a Coding problem. And not everyone is going to understand what another person explain 100% which is why i asked for hi to elaborate. We all need help with a mistake we made every once in awhile so he isn't really needed that Someone says "Read the -Guide-" every time someone messes up.
Aug 12 2008, 1:22 pm
In response to Bluebook
No, we say "Read the Guide" whenever someone sucks so horribly at coding due to not reading the guide and refuses to better themselves by reading the guide.

Read the guide, moron.
Aug 12 2008, 1:38 pm
In response to Bluebook
Bluebook wrote:
We all need help with a mistake we made every once in awhile

Point of Duh: That's the reason things like tutorials, the Guide and the Reference are made in the first place. Externally, it seems it should be obvious enough you should educate yourself on something (eg: swimming, programming, the DM language) before you do it, but some people need that to be explicitly said to them for one reason or another. Taking the swimming example, it's obvious you take the risk of possibly drowning if you don't educate yourself first, especially if you go in deeper waters. Programming is no different.
Aug 12 2008, 2:34 pm (Edited by moderator on Nov 7 2008, 9:39 pm)
In response to Glarfugus
I read the guide you idiot. I didn't understand everything read which is why we have a section for "coding problems".
Get your facts straight before you start insulting someone for a wookified reason.
Aug 12 2008, 2:42 pm
In response to Kaioken
Kaioken wrote:
Point of Duh: That's the reason things like tutorials, the Guide and the Reference are made in the first place. Externally, it seems it should be obvious enough you should educate yourself on something (eg: swimming, programming, the DM language) before you do it, but some people need that to be explicitly said to them for one reason or another. Taking the swimming example, it's obvious you take the risk of possibly drowning if you don't educate yourself first, especially if you go in deeper waters. Programming is no different.

I see what you are saying but thats not what i'm getting at >_<. I have read the DM guide but not the other Guide giantpanda posted. I'll probably look through it when i ge the chance but what i'm saying is that i didn't quite understand everything i read and would like some clarification on as what to do to fix this problem. Basically an explanation on why it isn't working.
Aug 12 2008, 2:43 pm
In response to Bluebook
No, we have the coding problems board for people who are willing to ask questions, and then not act like total Jacka**es.
Aug 12 2008, 3:01 pm
In response to Bluebook
Yes, reading something doesn't mean you always automatically understand it. Re-reading it and other resources later a couple of times usually helps, same for errors you get. Your error says what the problem is: you're not defining your proc properly. It's invalid. Defining a proc is quite a fundamental thing to do, which surely should be understood from beginner tutorials, which is why you get redirected there. 
    PK_Rockin for(var/mob/M in oview(1))

Procs simply aren't defined like that. You need to have the for() loop in the actual body of the proc, not the line that defines it and its name. Also, a pair of parentheses must always come after the proc name, even if it uses no arguments.
Aug 12 2008, 3:13 pm (Edited on Aug 12 2008, 3:36 pm)
In response to Giantpandaman
No panda.... He was trying to find help until Glarfugus started flaming him... You are also ganging up on him.

On topic: Like kaioken said. You may want to use the orange() proc instead of view here.
Aug 12 2008, 3:23 pm
In response to SourMonkey
SourMonkey wrote:
No panda.... He was trying to find help until Glarfugus started flaming him... You are also ganging up on him.

On topic: Like kaioken said. You may want to use the organge() proc instead of view here.

orange mate
Aug 13 2008, 8:17 am
Bluebook wrote:
Code:
>   PK_Rockin(var/mob/M in orange(1))
>           set category = "PSI"
>           //blah blah blah..
Aug 13 2008, 2:29 pm
In response to Andre-g1
That's not what he wanted, but at least that code compiles unlike his original version of it. >_>