I just cracked a gigantic bug by indenting 2 lines of codin

ID:182159
 
Nov 29 2008, 6:15 am (Edited on Nov 30 2008, 4:11 am)
Coding Before:
Bump(obj/Enemy/M)
    if(istype(M,/obj/Enemy))
        if(M)
            M.HP
        if(M.HP <= 0)
            M.loc = locate(1,0,1)
            spawn(500) del(M)
        for(var/mob/N in world)//<-----Problem
            N.gold += 1 + (1* round(N.wave/4))

Coding After:
Bump(obj/Enemy/M)
    if(istype(M,/obj/Enemy))
        if(M)
            M.HP
        if(M.HP <= 0)
            M.loc = locate(1,0,1)
            spawn(500) del(M)
            for(var/mob/N in world)//<-----Fixed
                N.gold += 1 + (1* round(N.wave/4))

It gave the person gold regardless of the enemy dying or not.
Nov 29 2008, 6:22 am
Um, congratulations? I thought it would be obvious as it is outside the if()s...

And I hope you didn't indent it after the del(src), otherwise it won't be called since the procedure will be terminated right there.
Nov 29 2008, 6:25 am
In response to GhostAnime
Actually it's kind of scrambled. It's supposed to delete the obj before the bullet.
Nov 29 2008, 10:42 am
In response to Choka
Still, if you're deleting the src before you mess with the gold, no one gets it!
Nov 29 2008, 10:45 am
In response to Jeff8500
I know, I fixed that as well.
Nov 29 2008, 8:07 pm
In response to Choka
Choka wrote:
I know, I fixed that as well.

Why would you post faulty code and call it fixed? More importantly, what's special about this situation? Developers do this kind of thing on a daily basis.
Nov 29 2008, 10:39 pm
In response to CaptFalcon33035
Because, I hadn't noticed it at all. Ontop of that the coding is outdated. I found no need to update it here when it quite clearly works.
Nov 30 2008, 1:38 am
In response to Choka
You NEED to update it here in case someone comes by and looks at it, who the HECK posts broken code on the forums, are you CRAZY!?
Nov 30 2008, 4:09 am
In response to Flame Sage
Possibly.
Nov 30 2008, 5:25 am
In response to Choka
Choka wrote:
Because, I hadn't noticed it at all. Ontop of that the coding is outdated. I found no need to update it here when it quite clearly works.

Then why did you post it? You are only misleading users. This is quite possibly the most worthless thread I have ever seen--providing misleading information and going nowhere. Now let's bring in the fact that it was started for no reason and the OP refuses to update his misleading code on the topic post...

[edit]
Okay, I see you edited the post, so thank you!

By the way, you can just set M.loc to null. You also may want to use a Bumped() procedure so that you may let Bump() proceed as intended. And this line does nothing: if(M) M.HP.
Nov 30 2008, 5:28 am
In response to CaptFalcon33035
Actually I did update it, a bit ago.
Nov 30 2008, 5:53 am
In response to CaptFalcon33035
CaptFalcon33035 wrote:
Then why did you post it? You are only misleading users. This is quite possibly the most worthless thread I have ever seen--providing misleading information and going nowhere. Now let's bring in the fact that it was started for no reason and the OP refuses to update his misleading code on the topic post...

I have to point out two things here:
1) No moderators have so far deleted this thread, which would be the case if your statements were true.
2) If you believe that this post is useless, why are you bothering to reply to it? If you don't, it'll die out more quickly than if you do, and it also avoids trolling.

Just a thought.

-01000100010101000100000100110011001100000011000100110001-

<small>Note: Not directly against you (your post pretty much sums it up), so don't take this personally or anything.</small>
Nov 30 2008, 5:56 am
In response to Android Data
Android Data wrote:
I have to point out two things here:
1) No moderators have so far deleted this thread, which would be the case if your statements were true.
2) If you believe that this post is useless, why are you bothering to reply to it? If you don't, it'll die out more quickly than if you do, and it also avoids trolling.

Valid points indeed. My aim was to get him to merely update his code, which he did so I am happy. :)
Nov 30 2008, 9:23 am
In response to CaptFalcon33035
This thread may now die in peace...