Ban system not working.

Page: 1 2 3
Aug 25 2010, 12:44 am
In response to NarutoBleach
Well, I added the things what you said, but the banned one can still login. This is what I got right now + the things I posted before, what Garthor asked for.
world/New()
    worldload()

world/Del()
    worldsave()
Aug 25 2010, 12:48 am
In response to Raimo
What do you mean can log in? Like they go onto the game, and is able to play? or what?
Aug 25 2010, 12:51 am
In response to NarutoBleach
Indeed. That's what I mean.
Aug 25 2010, 12:55 am
In response to Raimo
Umm.. Idk... cause I've tested the code exactly the way you posted... It works fine for me.
Aug 25 2010, 1:00 am
In response to NarutoBleach
Very weird.
Aug 25 2010, 1:03 am
In response to Raimo
Lol indeed... maybe you're testing it work? try banning yourself and then relogging.
Aug 25 2010, 1:09 am
In response to NarutoBleach
I tried that and I can still login and play.
Aug 25 2010, 10:20 am
In response to Raimo
When you ban the player, they are disconnected, the info pops up, etc. Right?

After you ban the player, output each element in the BanList list. Are they all valid?

When the player is banned, do they get any of the "you are banned" messages? Speaking of which, client/New should be changed slightly: the messages should be output to src, not usr. Also, the bans.len line just shouldn't be there at all (and the bans variable removed entirely, too).

In client/New(), output the key and every value in the BanList list (to the world). Are there any matches? Is there any output at all?


My guess is that you have a client/New() elsewhere which is interfering with this.
Aug 25 2010, 10:39 am
In response to Garthor
See, here's the better question: Why are you not using Dream Daemon's brilliant banning system?
Aug 25 2010, 10:45 am
In response to Garthor
I removed that bans.len line and the bans variable like you told me to do. Changed the output to src. And there is also no client/New() in all the other codes. Can you explain a bit more detailled? I would really appreciate that.

Thanks for all your help so far, and this is something I'm saying to everyone who helped me.
Aug 25 2010, 3:21 pm
In response to Raimo
My questions were not rhetorical.
Aug 26 2010, 4:45 am
In response to Garthor
Garthor wrote:
When you ban the player, they are disconnected, the info pops up, etc. Right?
info(null,world,"[BanKey] has been banned.([reason] - [src])")
This does indeed popup.
After you ban the player, output each element in the BanList list. Are they all valid?
proc
    addban(BanKey,BanIP)
        if(BanKey)BanList+=BanKey

The BanKey is added in the Banlist, because the proc is being called here: 
addban(BanKey,null)

When the player is banned, do they get any of the "you are banned" messages? Speaking of which, client/New should be changed slightly: the messages should be output to src, not usr. Also, the bans.len line just shouldn't be there at all (and the bans variable removed entirely, too).
When they login, they don't get any messages and they can still play the game.
In client/New(), output the key and every value in the BanList list (to the world). Are there any matches? Is there any output at all?
I'm not sure what you mean by that, if you can explain some more, I'll probably understand.
Aug 26 2010, 9:02 am
In response to Raimo
In client/New(), do this:

world << "MY KEY IS [key]"
world << "EVERY KEY IN THE BAN LIST:"
for(var/v in BanList)
  world << v


Additionally, saying "The BanKey is added in the Banlist, because the proc is being called here:" is completely totally not what I meant. Stop making assumptions. Actually DIRECTLY CHECK whether what you think is being done is ACTUALLY being done. That's how you find bugs. This means OUTPUTTING THE CONTENTS OF THE LIST, not saying "oh well it says it's calling the proc so clearly everything is working!"
Aug 26 2010, 9:48 am
In response to Garthor
Okay, I will and let you know what the result is in a few minutes. Sorry by the way.
Aug 26 2010, 10:05 am
In response to Garthor
Very weird, but those messages outputted to the world, aren't showing up either.
Aug 26 2010, 10:10 am
In response to Raimo
You have a client/New() elsewhere which is not calling ..() and is therefore blocking your current version from being called.
Aug 26 2010, 10:14 am
In response to Garthor
I don't got any other Client/New() in any of my file unless in one which is not included but that one is also calling ..()
Aug 26 2010, 10:19 am
In response to Raimo
Hold a second, I just did find one. I'm getting back to you in a few.
Aug 26 2010, 10:24 am
In response to Raimo
Okay, all the client/New() I've found are calling ..() .
Still, those messages which are outputted to the world don't show up.
Aug 26 2010, 11:34 am
In response to Raimo
You're wrong, then, because those are mutually exclusive.
Page: 1 2 3