Can Some Body Tell me About This ?

ID:156530
 
Sep 12 2010, 2:50 pm
 
turf/end
    icon = 'Finish.dmi'
    Entered()
        world << "[usr] has finally finished"
        usr.loc = locate(2,2,1)
        GiveMedal("Finished", src)
mob/proc/GiveMedal(var/medal)
    world.SetMedal(medal,usr)
    world.GetMedal(medal,usr)

Error:-
Maze.dm:44:error: GiveMedal: undefined proc
Sep 12 2010, 2:56 pm
 
turf/end
    icon = 'Finish.dmi'
    Entered(var/atom/a)
        if(ismob(a))//can't assume that only players will enter
            var/mob/M=a
            world << "[M] has finally finished"
            M.loc = locate(2,2,1)
            M.GiveMedal("Finished")//src was here :S
mob/proc/GiveMedal(var/medal)
    world.SetMedal(medal,usr)
    world.GetMedal(medal,usr)
Sep 12 2010, 2:57 pm
GiveMedal is a proc you defined for your player. You're trying to call src.GiveMedal() when src is /turf/end. Try usr.GiveMedal("Finished").
Sep 12 2010, 3:03 pm
In response to Kaiochao
usr is a VERY bad idea to use in Entered() and other movement related procedure - unless it is a single player game (and even at that...)

What if a projectile entered, for example? That's what Masschaos100's snippet takes into account.
Sep 12 2010, 3:05 pm
In response to GhostAnime
I had a complete brain fart. It's Entered(atom/movable/O), where O is what entered src.
Sep 12 2010, 3:17 pm
In response to Kaiochao

usr.GiveMedal("Finished") worked like a charm (You guys are great!

and i am making a single player game ^_^
Thanks
Sep 12 2010, 3:18 pm
In response to Taha123
don't use the usr thing, it'll give you runtimes in the long run, if enough non-mob movable atoms such as projectiles pass on it your game might crash
Sep 12 2010, 3:20 pm
In response to Masschaos100
so what do i use xD! src?
Sep 12 2010, 3:21 pm
In response to Masschaos100
 
Entered(atom/movable/Obj/O)
   O.GiveMedal("Finished")


is this correct?
Sep 12 2010, 3:26 pm
In response to Taha123
No, it doesn't really make sense since you want the procedure called on a /mob, not an /obj.

In addition, Entered() does not check the type of the object that enters. This means that Entered() can be called when an /obj enters the object, even though you specified "Entered(mob/M)".

See [link]
Sep 12 2010, 3:31 pm
In response to GhostAnime
you are all too wise .. i thank you ^_^
Sep 12 2010, 4:04 pm
In response to Masschaos100
He's only making a simple maze game with a character that must reach the end so I don't think he has go that far unless he wants to modify it further.
Sep 12 2010, 4:11 pm
In response to SSJCoop
offcourse i want to improve my games and my skills :P
Sep 12 2010, 7:35 pm
In response to SSJCoop
That is precisely as far as it has to be taken to do this properly. It is literally the bare minimum.