flick() displaying an overlay of the current icon_state while animating

ID:1375519
 
Sep 12 2013, 10:38 pm
Resolved
Flicks did not replace the original atom, for some kinds of atoms.
BYOND Version:500
Operating System:Windows 7 Ultimate 64-bit
Web Browser:Chrome 29.0.1547.66
Applies to:Dream Seeker
Status: Resolved (500.1206)
This issue has been resolved.
Descriptive Problem Summary:
When flick() is called, the icon animates the chosen state but a second "ghost" icon using the current icon_state is displayed over top like an overlay.

Numbered Steps to Reproduce Problem:
Create an icon with two states. Lets say "A" and "B"
set icon_state="A"
call flick("B",usr)


Code Snippet (if applicable) to Reproduce Problem:
flick("B",usr)


Expected Results:
Icon should animate as usual.

Actual Results:
Icon animates with an overlay of the current icon_state var over top it.

Does the problem occur:
Every time? Or how often?
Every time. Every flick() call
In other games?
I noticed it in Purgatory and all my old projects.
In other user accounts?
Someone mentioned it in The Big 500 topic.
On other computers?
Yes.
When does the problem NOT occur?
In versions before 500

Did the problem NOT occur in any earlier versions? If so, what was the last version that worked? 499

Workarounds:
Use 499 or animate()
Sep 12 2013, 10:41 pm
Descriptive Problem Summary:
I have a few images. seen here and here

Numbered Steps to Reproduce Problem:
flick("anything",anything)

Code Snippet (if applicable) to Reproduce Problem:
Just try flicking.


Expected Results:
Normal flicking of an atom.

Actual Results:

http://puu.sh/4q2K7.jpg
There seems to be a clone effect.

Does the problem occur:
Every time? Or how often?
Everytime.
In other games?
Yes, tested two thus far.
In other user accounts?
Idk, can't really login to my Pager atm.
On other computers?
Haven't tested.
When does the problem NOT occur?
It occurs 100% of the time.

Did the problem NOT occur in any earlier versions? If so, what was the last version that worked? 499

Workarounds:
None that I know of.
Sep 12 2013, 10:56 pm
I just posted over in Bug Reports forum but I guess this is the most appropriate place.

I too have this problem.
Do you also by chance have an issue with the compiler acting up?

For instance if I use ctrl +H to search, and then click on a line in the bottom window of the compiler, DM will freeze and crash.
Sep 12 2013, 11:01 pm
Dariuc, I am having that issue. Let's take it to a new thread.
Sep 12 2013, 11:04 pm
In response to Hiro the Dragon King
Do the honors kind sir.
Sep 13 2013, 8:50 am
I can confirm flick() is doing some mighty weird stuff.
Sep 13 2013, 10:11 am
I'm not sure what to look at in that screenshot (some kind of indicator where to look would be helpful when posting those), but I think I found the issue all the same. Apparently this was happening with objs and mobs, due to a stupid mistake in altering an internal routine. Turfs should be immune.
Sep 13 2013, 12:02 pm (Edited on Sep 13 2013, 12:45 pm)
Descriptive Problem Summary:
Yes
Numbered Steps to Reproduce Problem:
No
Code Snippet (if applicable) to Reproduce Problem:
mob/player
    proc
        _animate(state)
            var/new_state = "Walk"

            if(new_state != icon_state && !state) icon_state = new_state
            if(state)
                icon_state = state
                flick("[state]",src)


Expected Results:
flick
Actual Results:
not flick
Does the problem occur:
Every time? Or how often? Every time.
In other games? idk
In other user accounts? idk
On other computers? idk

When does the problem NOT occur?
When 500 wasn't downloaded on my computer.
Did the problem NOT occur in any earlier versions? If so, what was the last version that worked? (Visit http://www.byond.com/download/build to download old versions for testing.)
It did not occur in before 500.
Workarounds:
None.

GIF video:
http://puu.sh/4qtpL.gif

And no, there is not another object connected to the player. Happens to every mob that uses flick.
Sep 13 2013, 12:42 pm
In response to Ishuri
Ishuri wrote:
Descriptive Problem Summary:
Yes
Numbered Steps to Reproduce Problem:
No

wat
Sep 13 2013, 2:16 pm
Lummox JR resolved issue with message:
Flicks did not replace the original atom, for some kinds of atoms.
Sep 13 2013, 8:09 pm (Edited by moderator on Sep 14 2013, 4:25 am)
Descriptive Problem Summary:
In DreamSeeker, objects that are flick()ed will animate the other icon or icon_state, but the original icon will still be shown over the animation.


Code Snippet (if applicable) to Reproduce Problem:
client/verb/SetSquareState(S as text)
    // "state1" for stationary
    // "state2" for rotation
    // "state3" for rotation + delay
    _object.icon_state  = S

client/verb/FlickSquare()
    flick("state2",_object)

var/obj/_object = null

world/New()
    ..()
    _object = new
    _object.icon        = 'icons.dmi'
    _object.icon_state  = "state1"
    _object.loc         = locate(1,1,1)

image used is https://dl.dropboxusercontent.com/u/14221897/images/ icons.dmi


Expected Results:


Actual Results:


Does the problem occur:
Every time? Or how often?
Every time flick() is called.

In other games?
Not sure.

In other user accounts?
n/a

On other computers?
Not sure.

When does the problem NOT occur?
On prior versions of BYOND (v499 or below)

Workarounds:
Use version 499 for the time being.

Mod Note: This was filed against 500.1025
Sep 14 2013, 12:04 pm
Makeii, this was already fixed in 500.1206.